Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(531)

Issue 1949603003: Finer grain control over specifying which variables have invalid constant initializers. (Closed)

Created:
4 years, 7 months ago by scheglov
Modified:
4 years, 7 months ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Finer grain control over specifying which variables have invalid constant initializers. As you noticed, we don't need to resynthesize anything if we know that it is not a valid constant expression in advance. At the same time we sometimes need to be able to test with both valid and invalid initializers. R=paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/6aece2f7a6b586df1f3d098c26e7f95c053e0eca

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -4 lines) Patch
M pkg/analyzer/lib/src/summary/resynthesize.dart View 2 chunks +5 lines, -1 line 0 comments Download
M pkg/analyzer/test/src/summary/resynthesize_ast_test.dart View 1 chunk +6 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/summary/resynthesize_test.dart View 8 chunks +27 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 7 months ago (2016-05-03 20:53:08 UTC) #1
Paul Berry
lgtm
4 years, 7 months ago (2016-05-03 21:09:28 UTC) #2
scheglov
4 years, 7 months ago (2016-05-03 21:32:19 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6aece2f7a6b586df1f3d098c26e7f95c053e0eca (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698