Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1949593002: Fix gpu_ipc_service_unittests on Android (Closed)

Created:
4 years, 7 months ago by Mark Dittmer
Modified:
4 years, 7 months ago
Reviewers:
piman
CC:
chromium-reviews, piman+watch_chromium.org, Fady Samuel
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix gpu_ipc_service_unittests on Android BUG=608805 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/ef18d2f1f6e509d1e7acf481546fdd510e0cd703 Cr-Commit-Position: refs/heads/master@{#391324}

Patch Set 1 #

Patch Set 2 : Wrap Android-specific bits in if defined(OS_ANDROID) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -2 lines) Patch
M gpu/gpu.gyp View 2 chunks +6 lines, -0 lines 0 comments Download
M gpu/ipc/client/android/in_process_surface_texture_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M gpu/ipc/service/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download
M gpu/ipc/service/gpu_channel_unittest.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M gpu/ipc/service/gpu_memory_buffer_factory_test_template.h View 1 2 chunks +14 lines, -1 line 0 comments Download

Messages

Total messages: 18 (9 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1949593002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1949593002/1
4 years, 7 months ago (2016-05-03 17:21:57 UTC) #3
Mark Dittmer
+piman@ for review. PTAL. Need to land this before pushing https://codereview.chromium.org/1908013002/.
4 years, 7 months ago (2016-05-03 17:30:35 UTC) #6
Mark Dittmer
Wrap Android-specific bits in if defined(OS_ANDROID)
4 years, 7 months ago (2016-05-03 17:45:36 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1949593002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1949593002/20001
4 years, 7 months ago (2016-05-03 17:46:05 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-03 19:14:29 UTC) #11
piman
lgtm
4 years, 7 months ago (2016-05-03 19:17:26 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1949593002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1949593002/20001
4 years, 7 months ago (2016-05-03 19:19:45 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-03 19:22:51 UTC) #16
commit-bot: I haz the power
4 years, 7 months ago (2016-05-03 19:24:00 UTC) #18
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/ef18d2f1f6e509d1e7acf481546fdd510e0cd703
Cr-Commit-Position: refs/heads/master@{#391324}

Powered by Google App Engine
This is Rietveld 408576698