MD Settings: replace paper-material with paper-material-shared-styles

MD Settings: replace paper-material with paper-material-shared-styles

The cards don't need to be custom elements.

BUG=598516
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/2477b855edc8e00fbeb180b0e6011b83bbaf94a5
Cr-Commit-Position: refs/heads/master@{#391942}

[michaelpg, 2016-05-04 02:50:29]

Description was changed from

==========
MD Settings: replace paper-material with paper-material-shared-styles

The cards don't need to be custom elements.

BUG=598516
==========

to

==========
MD Settings: replace paper-material with paper-material-shared-styles

The cards don't need to be custom elements.

BUG=598516
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[michaelpg, 2016-05-04 02:54:08]

Patchset #1 (id:1) has been deleted

[michaelpg, 2016-05-04 02:55:25]

michaelpg@chromium.org changed reviewers:
+ dschuyler@chromium.org

[michaelpg, 2016-05-04 02:55:25]

PTAL

https://codereview.chromium.org/1949533003/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/settings_page/settings_section.html
(left):

https://codereview.chromium.org/1949533003/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/settings_page/settings_section.html:11:
<paper-material id="card" animated>
there is a corresponding TODO in main_page_behavior.js to adjust the elevation,
we'll deal "animated" then

[dschuyler, 2016-05-04 22:23:39]

https://codereview.chromium.org/1949533003/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/settings_page/settings_section.html
(right):

https://codereview.chromium.org/1949533003/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/settings_page/settings_section.html:8: <style
is="custom-style" include="settings-section-styles">
Is settings-section-styles likely to be used elsewhere?
If it's only used in one place, let's inline it here.

https://codereview.chromium.org/1949533003/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/settings_page/settings_section_css.html
(right):

https://codereview.chromium.org/1949533003/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/settings_page/settings_section_css.html:17:
color: rgb(104, 113, 116);
Is this a paper or google color? Can we use
a var(--foo-color-000) here?

If it's a custom color that was requested by
Alan, please add a comment to that effect.

[michaelpg, 2016-05-04 22:25:22]

https://codereview.chromium.org/1949533003/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/settings_page/settings_section_css.html
(right):

https://codereview.chromium.org/1949533003/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/settings_page/settings_section_css.html:17:
color: rgb(104, 113, 116);
On 2016/05/04 22:23:39, dschuyler wrote:
> Is this a paper or google color? Can we use
> a var(--foo-color-000) here?
> 
> If it's a custom color that was requested by
> Alan, please add a comment to that effect.

No idea, this is a copy-paste from a .css file.

[dschuyler, 2016-05-04 22:37:46]

https://codereview.chromium.org/1949533003/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/settings_page/settings_section_css.html
(right):

https://codereview.chromium.org/1949533003/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/settings_page/settings_section_css.html:17:
color: rgb(104, 113, 116);
On 2016/05/04 22:25:22, michaelpg wrote:
> On 2016/05/04 22:23:39, dschuyler wrote:
> > Is this a paper or google color? Can we use
> > a var(--foo-color-000) here?
> > 
> > If it's a custom color that was requested by
> > Alan, please add a comment to that effect.
> 
> No idea, this is a copy-paste from a .css file.

Okay, yeah, it's a custom color. Please make comment
about it being a custom color requested by UX/Alan.

[michaelpg, 2016-05-05 13:36:49]

https://codereview.chromium.org/1949533003/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/settings_page/settings_section.html
(right):

https://codereview.chromium.org/1949533003/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/settings_page/settings_section.html:8: <style
is="custom-style" include="settings-section-styles">
On 2016/05/04 22:23:39, dschuyler wrote:
> Is settings-section-styles likely to be used elsewhere?
> If it's only used in one place, let's inline it here.

Done.

https://codereview.chromium.org/1949533003/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/settings_page/settings_section_css.html
(right):

https://codereview.chromium.org/1949533003/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/settings_page/settings_section_css.html:17:
color: rgb(104, 113, 116);
On 2016/05/04 22:37:46, dschuyler wrote:
> On 2016/05/04 22:25:22, michaelpg wrote:
> > On 2016/05/04 22:23:39, dschuyler wrote:
> > > Is this a paper or google color? Can we use
> > > a var(--foo-color-000) here?
> > > 
> > > If it's a custom color that was requested by
> > > Alan, please add a comment to that effect.
> > 
> > No idea, this is a copy-paste from a .css file.
> 
> Okay, yeah, it's a custom color. Please make comment
> about it being a custom color requested by UX/Alan.

Done.

[dschuyler, 2016-05-05 18:47:32]

lgtm

[michaelpg, 2016-05-05 21:32:42]

The CQ bit was checked by michaelpg@chromium.org

[michaelpg, 2016-05-05 21:32:42]

The patchset sent to the CQ was uploaded after l-g-t-m from
dschuyler@chromium.org
Link to the patchset: https://codereview.chromium.org/1949533003/#ps80001
(title: "rebase")

[commit-bot: I haz the power, 2016-05-05 21:33:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1949533003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1949533003/80001

[commit-bot: I haz the power, 2016-05-05 23:18:19]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2016-05-05 23:20:15]

Description was changed from

==========
MD Settings: replace paper-material with paper-material-shared-styles

The cards don't need to be custom elements.

BUG=598516
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: replace paper-material with paper-material-shared-styles

The cards don't need to be custom elements.

BUG=598516
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/2477b855edc8e00fbeb180b0e6011b83bbaf94a5
Cr-Commit-Position: refs/heads/master@{#391942}
==========

[commit-bot: I haz the power, 2016-05-05 23:20:17]

Patchset 4 (id:??) landed as
https://crrev.com/2477b855edc8e00fbeb180b0e6011b83bbaf94a5
Cr-Commit-Position: refs/heads/master@{#391942}