Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Unified Diff: src/objects.cc

Issue 1949493004: Use Null as "no accessor" in AccessorPair instead of TheHole (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/factory.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/objects.cc
diff --git a/src/objects.cc b/src/objects.cc
index 98b3056eedf7e528247cf4624c63925aff438566..ae707016c78060257b46a62314fd46c5cb1d6416 100644
--- a/src/objects.cc
+++ b/src/objects.cc
@@ -9727,7 +9727,7 @@ Handle<Map> Map::TransitionToAccessorProperty(Handle<Map> map,
Object* current = Handle<AccessorPair>::cast(maybe_pair)->get(component);
if (current == *accessor) return map;
- if (!current->IsTheHole()) {
+ if (!current->IsNull()) {
return Map::Normalize(map, mode, "AccessorsOverwritingAccessors");
}
@@ -10341,7 +10341,7 @@ Handle<Object> AccessorPair::GetComponent(Handle<AccessorPair> accessor_pair,
.ToHandleChecked();
}
Isolate* isolate = accessor_pair->GetIsolate();
- if (accessor->IsTheHole()) {
+ if (accessor->IsNull()) {
return isolate->factory()->undefined_value();
}
return handle(accessor, isolate);
« no previous file with comments | « src/factory.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698