Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1949493004: Use Null as "no accessor" in AccessorPair instead of TheHole (Closed)

Created:
4 years, 7 months ago by jochen (gone - plz use gerrit)
Modified:
4 years, 7 months ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Use Null as "no accessor" in AccessorPair instead of TheHole R=verwaest@chromium.org BUG= Committed: https://crrev.com/d3b50cbb5cdcdc400c91ec65670c944d9fa59818 Cr-Commit-Position: refs/heads/master@{#36020}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M src/factory.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/objects.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
jochen (gone - plz use gerrit)
4 years, 7 months ago (2016-05-04 10:32:41 UTC) #1
Toon Verwaest
lgtm
4 years, 7 months ago (2016-05-04 11:27:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1949493004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1949493004/1
4 years, 7 months ago (2016-05-04 12:35:18 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-04 12:37:25 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-04 12:37:46 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/d3b50cbb5cdcdc400c91ec65670c944d9fa59818
Cr-Commit-Position: refs/heads/master@{#36020}

Powered by Google App Engine
This is Rietveld 408576698