[ignition] Disable dispatch table output by default

[ignition] Disable dispatch table output by default

BUG=

[Camillo Bruni, 2016-05-03 13:43:20]

cbruni@chromium.org changed reviewers:
+ rmcilroy@chromium.org, ssanfilippo@chromium.org

[Camillo Bruni, 2016-05-03 13:43:21]

PTAL, I like to have a clean working dir after running the tests :)

[rmcilroy, 2016-05-03 14:07:05]

On 2016/05/03 13:43:21, Camillo Bruni wrote:
> PTAL, I like to have a clean working dir after running the tests :)

Wait, this shouldn't be being output unless you pass
--trace_ignition_dispatches. Are you seeing it without this flag?

[Camillo Bruni, 2016-05-03 14:09:00]

On 2016/05/03 at 14:07:05, rmcilroy wrote:
> On 2016/05/03 13:43:21, Camillo Bruni wrote:
> > PTAL, I like to have a clean working dir after running the tests :)
> 
> Wait, this shouldn't be being output unless you pass
--trace_ignition_dispatches. Are you seeing it without this flag?

You set a default value which is not NULL so all the checks pass :) and assume
the flag set.

[rmcilroy, 2016-05-03 14:09:39]

On 2016/05/03 14:07:05, rmcilroy wrote:
> On 2016/05/03 13:43:21, Camillo Bruni wrote:
> > PTAL, I like to have a clean working dir after running the tests :)
> 
> Wait, this shouldn't be being output unless you pass
> --trace_ignition_dispatches. Are you seeing it without this flag?

Ahh, wait this is due to the mjsunit tests which sets that flag - Stefano, could
you instead have a look at ensuring the tests doesn't create this file (e.g.,
passing /dev/null or something to trace_ignition_dispatches_output_file for this
test)?

[Camillo Bruni, 2016-05-03 14:12:07]

On 2016/05/03 at 14:09:00, Camillo Bruni wrote:
> On 2016/05/03 at 14:07:05, rmcilroy wrote:
> > On 2016/05/03 13:43:21, Camillo Bruni wrote:
> > > PTAL, I like to have a clean working dir after running the tests :)
> > 
> > Wait, this shouldn't be being output unless you pass
--trace_ignition_dispatches. Are you seeing it without this flag?
> 
> You set a default value which is not NULL so all the checks pass :) and assume
the flag set.

Ah sorry misread, you should be right: for some reason I get the output file
when running all mjsunit tests with `tools/run-tests.py --mode Release --arch
x64 --buildbot --no-sorting -j 40 mjsunit`

[Camillo Bruni, 2016-05-03 14:15:22]

On 2016/05/03 at 14:12:07, Camillo Bruni wrote:
> On 2016/05/03 at 14:09:00, Camillo Bruni wrote:
> > On 2016/05/03 at 14:07:05, rmcilroy wrote:
> > > On 2016/05/03 13:43:21, Camillo Bruni wrote:
> > > > PTAL, I like to have a clean working dir after running the tests :)
> > > 
> > > Wait, this shouldn't be being output unless you pass
--trace_ignition_dispatches. Are you seeing it without this flag?
> > 
> > You set a default value which is not NULL so all the checks pass :) and
assume the flag set.
> 
> Ah sorry misread, you should be right: for some reason I get the output file
when running all mjsunit tests with `tools/run-tests.py --mode Release --arch
x64 --buildbot --no-sorting -j 40 mjsunit`

should be fine to just write to STDOUT if the file is not specified, that way
you can still test the code path.