Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1949433002: [turbofan] Fix OSR environment in for-in. (Closed)

Created:
4 years, 7 months ago by Jarin
Modified:
4 years, 7 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix OSR environment in for-in. BUG=chromium:607493 LOG=n Committed: https://crrev.com/2da181b08b66e127bba204fe4293c81e4f73ee3a Cr-Commit-Position: refs/heads/master@{#35982}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -10 lines) Patch
M src/compiler/ast-graph-builder.cc View 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/compiler/regress-607493.js View 1 chunk +8 lines, -9 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Jarin
Could you take a look, please?
4 years, 7 months ago (2016-05-03 13:10:40 UTC) #2
Michael Starzinger
LGTM.
4 years, 7 months ago (2016-05-03 13:18:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1949433002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1949433002/1
4 years, 7 months ago (2016-05-03 13:20:54 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-03 13:40:17 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-05-03 13:41:12 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/2da181b08b66e127bba204fe4293c81e4f73ee3a
Cr-Commit-Position: refs/heads/master@{#35982}

Powered by Google App Engine
This is Rietveld 408576698