Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 194943002: Pause the timeline on load in the SVGAnimationTestCase.js framework (Closed)

Created:
6 years, 9 months ago by fs
Modified:
6 years, 9 months ago
CC:
blink-reviews, shans, rjwright, alancutter (OOO until 2018), Mike Lawther (Google), dstockwell, Timothy Loh, darktears, Steve Block, dino_apple.com, Eric Willigers
Visibility:
Public.

Description

Pause the timeline on load in the SVGAnimationTestCase.js framework Most tests using this framework drive the "clock" / currentTime "manually" by setCurrentTime(t), and add the instance time of a click event to it. This means that there's a risk of rounding errors creeping in and causing the actual elapsed time to be off by a fraction - large enough to cause failures - at least for discrete animations. (Example: svglengthlist-animation-3.html) By pausing the timeline at 'load', the instance time for the click event will be '0', which should eliminate the risk of rounding issues. For the cases where the test actually need time to pass the timeline can be unpaused explicitly. (Currently only one testcase seemed to require that treatment.) BUG=350827 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169033

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M LayoutTests/svg/animations/resources/SVGAnimationTestCase.js View 2 chunks +5 lines, -3 lines 0 comments Download
M LayoutTests/svg/animations/script-tests/animate-endElement-beginElement.js View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
fs
6 years, 9 months ago (2014-03-11 13:20:31 UTC) #1
kouhei (in TOK)
lgtm
6 years, 9 months ago (2014-03-12 00:52:25 UTC) #2
fs
The CQ bit was checked by fs@opera.com
6 years, 9 months ago (2014-03-12 16:42:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/194943002/1
6 years, 9 months ago (2014-03-12 16:42:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/194943002/1
6 years, 9 months ago (2014-03-12 16:49:57 UTC) #5
commit-bot: I haz the power
6 years, 9 months ago (2014-03-12 16:53:42 UTC) #6
Message was sent while issue was closed.
Change committed as 169033

Powered by Google App Engine
This is Rietveld 408576698