Adding nacl component unit tests

Adding nacl component unit tests

BUG=604060
Committed: https://crrev.com/5982933b15bf02afd96c9d9deedfc334738a103b
Cr-Commit-Position: refs/heads/master@{#392112}

[brucedawson, 2016-05-05 17:22:55]

brucedawson@chromium.org changed reviewers:
+ dpranke@chromium.org

[brucedawson, 2016-05-05 17:22:55]

Can you sanity check this and advise?  This adds 6-7 source files that were
previously not being built in gn builds. I started setting up the deps by
copying from the browser source set in the same .gn file, but I found that left
me missing some deps, and left me with a dozen that "--check" said weren't
necessary. So, I removed as many as I could while still having "--check" succeed
on my Windows machine and I'm letting "git cl try" check my work on other
platforms.

Any suggestions on whether this is a reasonable technique? I've got another
dozen missing test source files after this batch - I've already done the easy
ones that didn't require a new source set.

[Dirk Pranke, 2016-05-05 17:59:25]

On 2016/05/05 17:22:55, brucedawson wrote:
> Can you sanity check this and advise?  This adds 6-7 source files that were
> previously not being built in gn builds. I started setting up the deps by
> copying from the browser source set in the same .gn file, but I found that
left
> me missing some deps, and left me with a dozen that "--check" said weren't
> necessary. So, I removed as many as I could while still having "--check"
succeed
> on my Windows machine and I'm letting "git cl try" check my work on other
> platforms.
> 
> Any suggestions on whether this is a reasonable technique? I've got another
> dozen missing test source files after this batch - I've already done the easy
> ones that didn't require a new source set.

Yup, I think that's a reasonable technique.

[Dirk Pranke, 2016-05-05 18:00:12]

dpranke@chromium.org changed reviewers:
+ phosek@chromium.org

[Dirk Pranke, 2016-05-05 18:00:13]

+phosek to review also ...

https://codereview.chromium.org/1949423002/diff/20001/components/nacl/browser...
File components/nacl/browser/BUILD.gn (right):

https://codereview.chromium.org/1949423002/diff/20001/components/nacl/browser...
components/nacl/browser/BUILD.gn:101: sources += [
"../zygote/nacl_fork_delegate_linux_unittest.cc" ]
nit: I think GN style would change this to //components/nacl/zygote/... as we
try to avoid ../ references, but I'm not actually positive about this.

[brucedawson, 2016-05-05 18:21:23]

Petr@ - don't look at this yet. Now that the try jobs are passing I need to do
some final cleanup, and perhaps get rid of the "../" reference.

[brucedawson, 2016-05-05 21:36:39]

Okay, PTAL Petr. This should be good to go.

https://codereview.chromium.org/1949423002/diff/20001/components/nacl/browser...
File components/nacl/browser/BUILD.gn (right):

https://codereview.chromium.org/1949423002/diff/20001/components/nacl/browser...
components/nacl/browser/BUILD.gn:101: sources += [
"../zygote/nacl_fork_delegate_linux_unittest.cc" ]
On 2016/05/05 18:00:13, Dirk Pranke wrote:
> nit: I think GN style would change this to //components/nacl/zygote/... as we
> try to avoid ../ references, but I'm not actually positive about this.

If nothing else this is consistent with lines 53-54 of this file, so I'm
inclined to leave it as is.

[Petr Hosek, 2016-05-05 23:09:40]

lgtm

[brucedawson, 2016-05-06 14:00:09]

The CQ bit was checked by brucedawson@chromium.org

[commit-bot: I haz the power, 2016-05-06 14:00:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1949423002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1949423002/40001

[commit-bot: I haz the power, 2016-05-06 14:05:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-06 14:05:41]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[brucedawson, 2016-05-06 14:20:14]

brucedawson@chromium.org changed reviewers:
+ caitkp@chromium.org

[brucedawson, 2016-05-06 14:20:14]

Adding an owner. caitkp@ PTAL

[Cait (Slow), 2016-05-06 18:48:38]

lgtm

[brucedawson, 2016-05-06 18:54:27]

The CQ bit was checked by brucedawson@chromium.org

[commit-bot: I haz the power, 2016-05-06 18:54:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1949423002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1949423002/40001

[commit-bot: I haz the power, 2016-05-06 19:03:13]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-05-06 19:04:30]

Description was changed from

==========
Adding nacl component unit tests

BUG=604060
==========

to

==========
Adding nacl component unit tests

BUG=604060

Committed: https://crrev.com/5982933b15bf02afd96c9d9deedfc334738a103b
Cr-Commit-Position: refs/heads/master@{#392112}
==========

[commit-bot: I haz the power, 2016-05-06 19:04:31]

Patchset 3 (id:??) landed as
https://crrev.com/5982933b15bf02afd96c9d9deedfc334738a103b
Cr-Commit-Position: refs/heads/master@{#392112}