X11: Better timestamp handling for _NET_ACTIVE_WINDOW

ui/events/platform/x11/x11_event_source.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/events/platform/x11/x11_event_source.h"
 
+#include <X11/Xatom.h>
 #include <X11/XKBlib.h>
 #include <X11/Xlib.h>
 
 #include "base/logging.h"
+#include "base/metrics/histogram_macros.h"
 #include "ui/events/devices/x11/device_data_manager_x11.h"
 #include "ui/events/event_utils.h"
 #include "ui/events/platform/platform_event_dispatcher.h"
 #include "ui/events/platform/x11/x11_hotplug_event_handler.h"
 
 namespace ui {
 
 namespace {
 
 bool InitializeXkb(XDisplay* display) {
@@ skipping 98 matching lines @@
 void X11EventSource::BlockUntilWindowMapped(XID window) {
   XEvent event;
   do {
     // Block until there's a message of |event_mask| type on |w|. Then remove
     // it from the queue and stuff it in |event|.
     XWindowEvent(display_, window, StructureNotifyMask, &event);
     ExtractCookieDataDispatchEvent(&event);
   } while (event.type != MapNotify);
 }
 
+static Bool is_property_notify_for_timestamp(Display* display,

[sky, 2016/05/07 16:58:34]

Move into anonymous namespace above, and no static, and if you can make arts
const where appropriate.

[Tom (Use chromium acct), 2016/05/09 17:49:59]

Done.

+                                             XEvent* event,
+                                             XPointer arg) {
+  return event->type == PropertyNotify &&
+      event->xproperty.window == DefaultRootWindow(display) &&
+      event->xproperty.atom == *(Atom*)arg;
+}
+
+Time X11EventSource::UpdateServerTime() {

[sky, 2016/05/07 16:58:34]

UpdateLastSeenServerTime?

[Tom (Use chromium acct), 2016/05/09 17:50:00]

Done.

+  base::TimeTicks start = base::TimeTicks::Now();
+
+  const char kAtomStr[] = "X11_EVENT_SOURCE_UPDATE_SERVER_TIME_DUMMY_ATOM";
+
+  DCHECK(display_);
+  Window window = DefaultRootWindow(display_);
+  const unsigned char dummyData = 0;

[sky, 2016/05/07 16:58:34]

dummy_data and dummy_atom. Also, please add comments here as it isn't at all
obvious why this code is here.

[Tom (Use chromium acct), 2016/05/09 17:49:59]

Done.

+  Atom dummyAtom = XInternAtom(display_, kAtomStr, False);
+
+  XSelectInput(display_, window, PropertyChangeMask);
+
+  XChangeProperty(display_, window, dummyAtom, XA_INTEGER, 8, PropModeReplace,
+                  &dummyData, 1);
+
+  XEvent event;
+  XIfEvent(display_, &event, is_property_notify_for_timestamp,
+           (XPointer)&dummyAtom);
+
+  XDeleteProperty(display_, window, dummyAtom);
+  XFlush(display_);
+
+  last_seen_server_time_ = event.xproperty.time;
+
+  UMA_HISTOGRAM_TIMES("Event.Latency.X11EventSource.UpdateServerTime",
+                      base::TimeTicks::Now() - start);
+  return last_seen_server_time_;
+}
+
 ////////////////////////////////////////////////////////////////////////////////
 // X11EventSource, protected
 
 void X11EventSource::ExtractCookieDataDispatchEvent(XEvent* xevent) {
   bool have_cookie = false;
   if (xevent->type == GenericEvent &&
       XGetEventData(xevent->xgeneric.display, &xevent->xcookie)) {
     have_cookie = true;
   }
   Time event_time = ExtractTimeFromXEvent(*xevent);
@@ skipping 36 matching lines @@
 
 void X11EventSource::OnDispatcherListChanged() {
   if (!hotplug_event_handler_) {
     hotplug_event_handler_.reset(new X11HotplugEventHandler());
     // Force the initial device query to have an update list of active devices.
     hotplug_event_handler_->OnHotplugEvent();
   }
 }
 
 }  // namespace ui