X11: Better timestamp handling for _NET_ACTIVE_WINDOW

ui/events/platform/x11/x11_event_source.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/events/platform/x11/x11_event_source.h"
 
+#include <X11/Xatom.h>
 #include <X11/XKBlib.h>
 #include <X11/Xlib.h>
 
 #include "base/logging.h"
+#include "base/metrics/histogram_macros.h"
 #include "ui/events/devices/x11/device_data_manager_x11.h"
 #include "ui/events/devices/x11/touch_factory_x11.h"
 #include "ui/events/event_utils.h"
 #include "ui/events/platform/platform_event_dispatcher.h"
 #include "ui/events/platform/x11/x11_hotplug_event_handler.h"
 
 namespace ui {
 
 namespace {
 
@@ skipping 50 matching lines @@
   return CurrentTime;
 }
 
 void UpdateDeviceList() {
   XDisplay* display = gfx::GetXDisplay();
   DeviceListCacheX11::GetInstance()->UpdateDeviceList(display);
   TouchFactory::GetInstance()->UpdateDeviceList(display);
   DeviceDataManagerX11::GetInstance()->UpdateDeviceList(display);
 }
 
+Bool IsPropertyNotifyForTimestamp(Display* display,
+                                  XEvent* event,
+                                  XPointer arg) {
+  return event->type == PropertyNotify &&
+         event->xproperty.window == *(Window*)arg;

[danakj, 2016/05/12 23:35:48]

C++ style casts please

[Tom (Use chromium acct), 2016/05/13 17:21:25]

Done.

+}
+
 }  // namespace
 
 X11EventSource* X11EventSource::instance_ = nullptr;
 
 X11EventSource::X11EventSource(X11EventSourceDelegate* delegate,
                                XDisplay* display)
     : delegate_(delegate),
       display_(display),
       last_seen_server_time_(CurrentTime),
+      dummy_initialized_(false),
       continue_stream_(true) {
   DCHECK(!instance_);
   instance_ = this;
 
   DCHECK(delegate_);
   DCHECK(display_);
   DeviceDataManagerX11::CreateInstance();
   InitializeXkb(display_);
 }
 
 X11EventSource::~X11EventSource() {
   DCHECK_EQ(this, instance_);
   instance_ = nullptr;
+  if (dummy_initialized_)
+    XDestroyWindow(display_, dummy_window_);
 }
 
 // static
 X11EventSource* X11EventSource::GetInstance() {
   DCHECK(instance_);
   return instance_;
 }
 
 ////////////////////////////////////////////////////////////////////////////////
 // X11EventSource, public
@@ skipping 14 matching lines @@
 void X11EventSource::BlockUntilWindowMapped(XID window) {
   XEvent event;
   do {
     // Block until there's a message of |event_mask| type on |w|. Then remove
     // it from the queue and stuff it in |event|.
     XWindowEvent(display_, window, StructureNotifyMask, &event);
     ExtractCookieDataDispatchEvent(&event);
   } while (event.type != MapNotify);
 }
 
+Time X11EventSource::UpdateLastSeenServerTime() {
+  base::TimeTicks start = base::TimeTicks::Now();
+
+  DCHECK(display_);
+
+  if (!dummy_initialized_) {
+    // Create a new Window and Atom that will be used for the property change.
+    dummy_data_ = 0;
+    dummy_window_ = XCreateSimpleWindow(display_, DefaultRootWindow(display_),
+                                        0, 0, 1, 1, 0, 0, 0);
+    dummy_atom_ = XInternAtom(display_, "TIMESTAMP", False);

[danakj, 2016/05/12 23:33:26]

Can you namespace this like CHROMIUM_TIMESTAMP

[Tom (Use chromium acct), 2016/05/13 17:21:25]

Done.

+    XSelectInput(display_, dummy_window_, PropertyChangeMask);
+    dummy_initialized_ = true;
+  }
+
+  // Make a no-op property change on |dummy_window_|.
+  dummy_data_++;
+  XChangeProperty(display_, dummy_window_, dummy_atom_, XA_INTEGER, 8,

[danakj, 2016/05/12 23:33:26]

I believe you can do this and avoid the need for dummy_data_:

XChangeProperty(display_, dummy_window_, dummy_atom_, XA_STRING, 8,
                PropModeAppend, nullptr, 0);

[Tom (Use chromium acct), 2016/05/13 17:21:25]

Done.  Also, cool!

+                  PropModeReplace, &dummy_data_, 1);
+
+  // Observe the resulting PropertyNotify event to obtain the timestamp.
+  XEvent event;
+  XIfEvent(display_, &event, IsPropertyNotifyForTimestamp,
+           (XPointer)&dummy_window_);

[danakj, 2016/05/12 23:35:48]

Oh, c++-style casts please.

+
+  last_seen_server_time_ = event.xproperty.time;
+
+  UMA_HISTOGRAM_TIMES("Event.Latency.X11EventSource.UpdateServerTime",
+                      base::TimeTicks::Now() - start);
+  return last_seen_server_time_;
+}
+
 ////////////////////////////////////////////////////////////////////////////////
 // X11EventSource, protected
 
 void X11EventSource::ExtractCookieDataDispatchEvent(XEvent* xevent) {
   bool have_cookie = false;
   if (xevent->type == GenericEvent &&
       XGetEventData(xevent->xgeneric.display, &xevent->xcookie)) {
     have_cookie = true;
   }
   Time event_time = ExtractTimeFromXEvent(*xevent);
@@ skipping 36 matching lines @@
 
 void X11EventSource::OnDispatcherListChanged() {
   if (!hotplug_event_handler_) {
     hotplug_event_handler_.reset(new X11HotplugEventHandler());
     // Force the initial device query to have an update list of active devices.
     hotplug_event_handler_->OnHotplugEvent();
   }
 }
 
 }  // namespace ui