Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(537)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1949393006: Remove deprecated uses of WeakCallbackData from tests. (Closed)

Created:
4 years, 7 months ago by ulan
Modified:
4 years, 7 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove deprecated uses of WeakCallbackData from tests. BUG=chromium:609808 LOG=NO Committed: https://crrev.com/0dfc1613b513c1df26c4155a47dec4181c1cbd1b Cr-Commit-Position: refs/heads/master@{#36074}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -65 lines) Patch
M test/cctest/heap/test-heap.cc View 4 chunks +10 lines, -10 lines 0 comments Download
M test/cctest/heap/test-mark-compact.cc View 5 chunks +28 lines, -29 lines 0 comments Download
M test/cctest/test-weakmaps.cc View 2 chunks +4 lines, -13 lines 0 comments Download
M test/cctest/test-weaksets.cc View 2 chunks +4 lines, -13 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
ulan
ptal
4 years, 7 months ago (2016-05-06 11:59:40 UTC) #2
jochen (gone - plz use gerrit)
lgtm
4 years, 7 months ago (2016-05-06 12:00:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1949393006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1949393006/1
4 years, 7 months ago (2016-05-06 12:02:25 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-06 12:29:08 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-06 12:30:16 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/0dfc1613b513c1df26c4155a47dec4181c1cbd1b
Cr-Commit-Position: refs/heads/master@{#36074}

Powered by Google App Engine
This is Rietveld 408576698