DevTools: introduce Storage.clearDataForOrigin protocol command.

DevTools: introduce Storage.clearDataForOrigin protocol command.

BUG=609390
Committed: https://crrev.com/86ec8381b5249eb63c9d137a8df9ce843e9adb47
Cr-Commit-Position: refs/heads/master@{#392121}

[pfeldman, 2016-05-05 06:17:28]

Description was changed from

==========
DevTools: [wip] introduce Storage.clearDataForOrigin protocol command.

BUG=609390
==========

to

==========
DevTools: [wip] introduce Storage.clearDataForOrigin protocol command.

BUG=609390
==========

[pfeldman, 2016-05-05 06:17:36]

Description was changed from

==========
DevTools: [wip] introduce Storage.clearDataForOrigin protocol command.

BUG=609390
==========

to

==========
DevTools: introduce Storage.clearDataForOrigin protocol command.

BUG=609390
==========

[pfeldman, 2016-05-05 06:17:51]

pfeldman@chromium.org changed reviewers:
+ caseq@chromium.org

[pfeldman, 2016-05-05 23:04:31]

The CQ bit was checked by pfeldman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-05 23:05:10]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1949373002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1949373002/1

[caseq, 2016-05-05 23:23:42]

https://codereview.chromium.org/1949373002/diff/1/content/browser/devtools/pr...
File content/browser/devtools/protocol/storage_handler.cc (right):

https://codereview.chromium.org/1949373002/diff/1/content/browser/devtools/pr...
content/browser/devtools/protocol/storage_handler.cc:53: if
(storage_types.find(kAppCache) != std::string::npos)
This approach will break when one of the option would be a substring of another.
Let's first split them, then find in the array. Better yet, pass the array of
the enums?

https://codereview.chromium.org/1949373002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/protocol.json (right):

https://codereview.chromium.org/1949373002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/protocol.json:5151: { "name": "storageTypes",
"type": "string", "description": "Comma separated origin names." },
Ah, so we've got an enum, but pass it as string?!

[commit-bot: I haz the power, 2016-05-06 00:48:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-06 00:48:42]

Dry run: This issue passed the CQ dry run.

[pfeldman, 2016-05-06 07:24:38]

https://codereview.chromium.org/1949373002/diff/1/content/browser/devtools/pr...
File content/browser/devtools/protocol/storage_handler.cc (right):

https://codereview.chromium.org/1949373002/diff/1/content/browser/devtools/pr...
content/browser/devtools/protocol/storage_handler.cc:53: if
(storage_types.find(kAppCache) != std::string::npos)
On 2016/05/05 23:23:42, caseq wrote:
> This approach will break when one of the option would be a substring of
another.
> Let's first split them, then find in the array. Better yet, pass the array of
> the enums?

It is efficient though and accounts for the same number of lines. And there are
no substrings!

https://codereview.chromium.org/1949373002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/protocol.json (right):

https://codereview.chromium.org/1949373002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/protocol.json:5151: { "name": "storageTypes",
"type": "string", "description": "Comma separated origin names." },
On 2016/05/05 23:23:42, caseq wrote:
> Ah, so we've got an enum, but pass it as string?!

We don't generate them and it is hard for us to parse complex input parameters
(we never do that). The enum is here for documentation purposes only.

[pfeldman, 2016-05-06 07:26:56]

i'll fix it in an interesting way!

[pfeldman, 2016-05-06 14:45:54]

On 2016/05/06 07:26:56, pfeldman wrote:
> i'll fix it in an interesting way!

failed to - went with boring one.

[caseq, 2016-05-06 18:13:09]

lgtm

https://codereview.chromium.org/1949373002/diff/20001/content/browser/devtool...
File content/browser/devtools/protocol/storage_handler.cc (right):

https://codereview.chromium.org/1949373002/diff/20001/content/browser/devtool...
content/browser/devtools/protocol/storage_handler.cc:58: if (set.find(kAppCache)
!= set.end())
nit:

since you're using set, just

if (set.count(kAppCache)) ...

https://codereview.chromium.org/1949373002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/protocol.json (right):

https://codereview.chromium.org/1949373002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/protocol.json:5143: "all" ],
], => next line

https://codereview.chromium.org/1949373002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/protocol.json:5144: "description": "Enum of
possible storage types."
indent!

[pfeldman, 2016-05-06 18:20:29]

all done

[pfeldman, 2016-05-06 18:20:34]

The CQ bit was checked by pfeldman@chromium.org

[pfeldman, 2016-05-06 18:20:35]

The patchset sent to the CQ was uploaded after l-g-t-m from caseq@chromium.org
Link to the patchset: https://codereview.chromium.org/1949373002/#ps40001
(title: "comments addressed")

[commit-bot: I haz the power, 2016-05-06 18:21:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1949373002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1949373002/40001

[commit-bot: I haz the power, 2016-05-06 19:30:50]

Description was changed from

==========
DevTools: introduce Storage.clearDataForOrigin protocol command.

BUG=609390
==========

to

==========
DevTools: introduce Storage.clearDataForOrigin protocol command.

BUG=609390
==========

[commit-bot: I haz the power, 2016-05-06 19:30:51]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-05-06 19:32:36]

Description was changed from

==========
DevTools: introduce Storage.clearDataForOrigin protocol command.

BUG=609390
==========

to

==========
DevTools: introduce Storage.clearDataForOrigin protocol command.

BUG=609390

Committed: https://crrev.com/86ec8381b5249eb63c9d137a8df9ce843e9adb47
Cr-Commit-Position: refs/heads/master@{#392121}
==========

[commit-bot: I haz the power, 2016-05-06 19:32:37]

Patchset 3 (id:??) landed as
https://crrev.com/86ec8381b5249eb63c9d137a8df9ce843e9adb47
Cr-Commit-Position: refs/heads/master@{#392121}