Add ability to create CSV of Stale Test Expectations with list of all bugs and filenames

third_party/WebKit/Tools/Scripts/print-stale-test-expectations-entries

 #!/usr/bin/python
 #
 # Copyright (C) 2013 Google Inc. All rights reserved.
 #
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are
 # met:
 #
 #     * Redistributions of source code must retain the above copyright
 # notice, this list of conditions and the following disclaimer.
@@ skipping 12 matching lines @@
 # OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
 # SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
 # LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
 # DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
 # THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
 # (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
 """Prints lists of bug numbers / tests whose bugs haven't been modified recently."""
 
+import csv
 import datetime
 import json
 import optparse
 import re
 import sys
 import time
 import urllib2
 
 from webkitpy.common.system.filesystem import FileSystem
 from webkitpy.common.webkit_finder import WebKitFinder
 
 google_code_url = 'https://www.googleapis.com/projecthosting/v2/projects/chromium/issues/%s?key=AIzaSyDgCqT1Dt5AZWLHo4QJjyMHaCjhnFacGF0'
 crbug_prefix = 'crbug.com/'
 
+class StaleTestCSV(object):

[nainar, 2016/05/05 05:02:50]

I am creating an output csv right now - this seems like the best way as we move
to automate this process

+    def __init__(self, filename):
+        self._filename = filename
+        self._writer = csv.writer(open(filename, 'wb'), delimiter=',', quotechar='|', quoting=csv.QUOTE_MINIMAL, lineterminator='\n')

[Dirk Pranke, 2016/05/06 01:51:55]

using '|' as a quotechar seems like an odd choice.

I'd either be inclined to just use the default excel dialect, or skip the csv
module altogether since we control the format and just do file.write("%d,%s\n" %
(bug_number, test_name)).

[nainar, 2016/05/11 13:24:35]

Done.

+
+    def add_to_csv(self, bug_number, test_name):
+        self._writer.writerow([bug_number, test_name])
+
 class StaleTestPrinter(object):
     def __init__(self, options):
         self._days = options.days
+        self._stale_test_csv = StaleTestCSV(options.create_csv)
 
     def is_stale(self, bug_number):
         url = google_code_url % bug_number
         response = urllib2.urlopen(url)
         parsed = json.loads(response.read())
         last_updated = parsed['updated']
         parsed_time = datetime.datetime.strptime(last_updated.split(".")[0]+"UTC", "%Y-%m-%dT%H:%M:%S%Z")
         time_delta = datetime.datetime.now() - parsed_time
-        return time_delta.days > 90
+        return time_delta.days > (self._days if self._days else 90)

[Dirk Pranke, 2016/05/06 01:51:55]

you don't really need the if since self._days will default to 90.

[nainar, 2016/05/11 13:24:36]

Done.

 
     def print_stale_tests(self):
         finder = WebKitFinder(FileSystem())
         path_to_expectations = finder.path_from_webkit_base('LayoutTests', 'TestExpectations')
         expectations = open(path_to_expectations)
 
         for line in expectations:
             comment_index = line.find("#")
             if comment_index == -1:
                 comment_index = len(line)
@@ skipping 12 matching lines @@
                             is_bug_stale = False
                             break;
                     except urllib2.HTTPError as error:
                         if error.code == 404:
                             print '%s%s does not exist.' % (crbug_prefix, bug_number)
                         elif error.code == 403:
                             print '%s%s is not accessible. Not able to tell if it\'s stale.' % (crbug_prefix, bug_number)
                             is_bug_stale = False
                         else:
                             raise error
+                elif len(part) and not (part.startswith('[') or part.startswith(']') or part[0].isupper()) and is_bug_stale is True:
+                    test_name = part
 
             if is_bug_stale:
                 print line.strip()
+                if self._stale_test_csv._filename:
+                    self._stale_test_csv.add_to_csv(bug_number, test_name)

[Dirk Pranke, 2016/05/06 01:51:55]

Ick. We shouldn't be parsing the file by hand. Do something like this instead:

from webkitpy.common.host import Host
from webkitpy.layout_tests.models.test_expectations import
TestExpectationsParser

port = Host().port_factory.get()
exps = port.expectations_dict()
parser = TestExpectationsParser(port, all_tests=True, is_lint_mode=False)
for line in parser.parse(*exps.items()[0]): # The first item is the filename and
contents of LayoutTests/TestExpectations
  bugs, name = line.bugs, line.name  # there can be more than one bug# !
  try:
    if bugs and all(self.is_stale(bug) for bug in bugs):
      print line.original_string.strip()
      if self._stale_test_csv._filename:
       self._stale_test_csv.add_to_csv(...)
  except:
    ...

[nainar, 2016/05/11 13:24:36]

Done.

+
 
 def main(argv):
     option_parser = optparse.OptionParser()
     option_parser.add_option('--days', type='int', default=90, help='Number of days to consider a bug stale.'),
+    option_parser.add_option('--create-csv', type='string', default=0, help='Generate a CSV of the stale entries as well. Followed by the filename.'),
     options, args = option_parser.parse_args(argv)
 
     printer = StaleTestPrinter(options)
     printer.print_stale_tests()
     return 0
 
 if __name__ == '__main__':
     sys.exit(main(sys.argv[1:]))