Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(477)

Unified Diff: net/quic/crypto/proof_verifier_chromium.cc

Issue 1949333002: QUIC - minor debugging logic to see why SCT verification is failing when (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: use VLOG Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/crypto/proof_verifier_chromium.cc
diff --git a/net/quic/crypto/proof_verifier_chromium.cc b/net/quic/crypto/proof_verifier_chromium.cc
index 93d9721bede60fe1f1ea4e125f6225388198c998..e6e9516eef078f10cbed121bc1c58f5117eb1a64 100644
--- a/net/quic/crypto/proof_verifier_chromium.cc
+++ b/net/quic/crypto/proof_verifier_chromium.cc
@@ -212,9 +212,22 @@ QuicAsyncStatus ProofVerifierChromium::Job::VerifyProof(
// Note that this is a completely synchronous operation: The CT Log Verifier
// gets all the data it needs for SCT verification and does not do any
// external communication.
- cert_transparency_verifier_->Verify(cert_.get(), std::string(), cert_sct,
- &verify_details_->ct_verify_result,
- net_log_);
+ int result = cert_transparency_verifier_->Verify(
+ cert_.get(), std::string(), cert_sct,
+ &verify_details_->ct_verify_result, net_log_);
+ // TODO(rtenneti): Delete this debugging code.
+ if (result == OK) {
+ VLOG(1) << "CTVerifier::Verify success";
+ } else {
+ VLOG(1) << "CTVerifier::Verify failed: " << result;
+ }
+ } else {
+ // TODO(rtenneti): Delete this debugging code.
+ if (cert_transparency_verifier_) {
+ VLOG(1) << "cert_sct is empty";
+ } else {
+ VLOG(1) << "cert_transparency_verifier_ is null";
+ }
}
// We call VerifySignature first to avoid copying of server_config and
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698