QUIC - minor debugging logic to see why SCT verification is failing when

net/quic/crypto/proof_verifier_chromium.cc

Index: net/quic/crypto/proof_verifier_chromium.cc
diff --git a/net/quic/crypto/proof_verifier_chromium.cc b/net/quic/crypto/proof_verifier_chromium.cc
index 93d9721bede60fe1f1ea4e125f6225388198c998..7c93ae7924f03d5edf556e849f2ddadcca329f46 100644
--- a/net/quic/crypto/proof_verifier_chromium.cc
+++ b/net/quic/crypto/proof_verifier_chromium.cc
@@ -212,9 +212,22 @@ QuicAsyncStatus ProofVerifierChromium::Job::VerifyProof(
     // Note that this is a completely synchronous operation: The CT Log Verifier
     // gets all the data it needs for SCT verification and does not do any
     // external communication.
-    cert_transparency_verifier_->Verify(cert_.get(), std::string(), cert_sct,
-                                        &verify_details_->ct_verify_result,
-                                        net_log_);
+    int result = cert_transparency_verifier_->Verify(
+        cert_.get(), std::string(), cert_sct,
+        &verify_details_->ct_verify_result, net_log_);
+    // TODO(rtenneti): Delete this debugging code.
+    if (result == OK) {
+      DVLOG(1) << "CTVerifier::Verify success";
+    } else {
+      DVLOG(1) << "CTVerifier::Verify failed: " << result;
+    }
+  } else {
+    // TODO(rtenneti): Delete this debugging code.
+    if (cert_transparency_verifier_) {
+      DVLOG(1) << "cert_sct is empty";
+    } else {
+      DVLOG(1) << "cert_transparency_verifier_ is null";

[Ryan Hamilton, 2016/05/05 03:55:32]

Since these are *D*VLOGs, will they be removed from release builds? Will that
help you?

[ramant (doing other things), 2016/05/05 17:48:08]

Was brain dead. Thanks much for catching this. Used VLOG.

Done.

+    }
   }
 
   // We call VerifySignature first to avoid copying of server_config and