Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 19493005: Avoid adding HWrapReceiver during graph building. (Closed)

Created:
7 years, 5 months ago by Michael Starzinger
Modified:
7 years, 5 months ago
Reviewers:
titzer
CC:
v8-dev
Visibility:
Public.

Description

Avoid adding HWrapReceiver during graph building. This adds an early check to the graph builder which prevents adding an HWrapReceiver instruction if the receiver type is already known at graph building time. Also HAllocate no longer unnecessarily postpones setting it's type until type inference but sets it right away. These changes are in preparation for escape analysis. R=titzer@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=15843

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -20 lines) Patch
M src/hydrogen.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/hydrogen.cc View 3 chunks +9 lines, -4 lines 0 comments Download
M src/hydrogen-instructions.h View 6 chunks +4 lines, -11 lines 0 comments Download
M src/hydrogen-instructions.cc View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Starzinger
Easy solution for one of my problems I mentioned today. :)
7 years, 5 months ago (2013-07-23 20:56:53 UTC) #1
titzer
lgtm
7 years, 5 months ago (2013-07-24 07:25:46 UTC) #2
Michael Starzinger
7 years, 5 months ago (2013-07-24 08:05:55 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r15843 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698