Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(675)

Issue 1949293002: Further expand parsing tests around yield in generator/arrow parameters (Closed)

Created:
4 years, 7 months ago by adamk
Modified:
4 years, 7 months ago
Reviewers:
Dan Ehrenberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Further expand parsing tests around yield in generator/arrow parameters No bugs found, but the additional coverage of arrows as default param initializers in a generator param list seems good to have. R=littledan@chromium.org Committed: https://crrev.com/0783a6fc277fad5e308940eee747d8170f88eb7b Cr-Commit-Position: refs/heads/master@{#36089}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M test/cctest/test-parsing.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
adamk
4 years, 7 months ago (2016-05-04 23:53:30 UTC) #1
Dan Ehrenberg
lgtm
4 years, 7 months ago (2016-05-04 23:56:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1949293002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1949293002/1
4 years, 7 months ago (2016-05-06 18:59:06 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-06 19:30:46 UTC) #5
commit-bot: I haz the power
4 years, 7 months ago (2016-05-06 19:32:00 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0783a6fc277fad5e308940eee747d8170f88eb7b
Cr-Commit-Position: refs/heads/master@{#36089}

Powered by Google App Engine
This is Rietveld 408576698