Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(602)

Unified Diff: services/ui/view_manager/view_registry.cc

Issue 1949233002: Create a RegisterViewAssociate method in ViewManager (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: one more compile fix Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: services/ui/view_manager/view_registry.cc
diff --git a/services/ui/view_manager/view_registry.cc b/services/ui/view_manager/view_registry.cc
index aee3a466f8af2e4d34c76db26fa1c66fc8244d83..1a70f73589705a47de43b3a59754dda9f66fed6f 100644
--- a/services/ui/view_manager/view_registry.cc
+++ b/services/ui/view_manager/view_registry.cc
@@ -59,14 +59,21 @@ ViewRegistry::ViewRegistry(mojo::gfx::composition::CompositorPtr compositor)
ViewRegistry::~ViewRegistry() {}
-void ViewRegistry::ConnectAssociates(
- mojo::ApplicationImpl* app_impl,
- const std::vector<std::string>& urls,
- const AssociateConnectionErrorCallback& connection_error_callback) {
- associate_table_.ConnectAssociates(app_impl, this, urls,
- connection_error_callback);
+// REGISTERING ASSOCIATES
+
+void ViewRegistry::RegisterViewAssociate(
+ mojo::ui::ViewInspector* view_inspector,
+ mojo::ui::ViewAssociatePtr view_associate,
+ mojo::InterfaceRequest<mojo::ui::ViewAssociateOwner> view_associate_owner,
+ const mojo::String& label) {
+ associate_table_.RegisterViewAssociate(view_inspector, view_associate.Pass(),
jeffbrown 2016/05/18 18:07:16 Please sanitize the label here before using it. S
mikejurka 2016/05/18 19:09:10 Done.
+ view_associate_owner.Pass(), label);
}
+void ViewRegistry::FinishedRegisteringViewAssociates() {
+ associate_table_.FinishedRegisteringViewAssociates();
+};
+
// CREATE / DESTROY VIEWS
void ViewRegistry::CreateView(
« services/ui/view_manager/view_associate_table.cc ('K') | « services/ui/view_manager/view_registry.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698