Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Unified Diff: mojo/services/ui/views/interfaces/view_associates.mojom

Issue 1949233002: Create a RegisterViewAssociate method in ViewManager (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: one more compile fix Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/services/ui/views/interfaces/view_associates.mojom
diff --git a/mojo/services/ui/views/interfaces/view_associates.mojom b/mojo/services/ui/views/interfaces/view_associates.mojom
index 8fcac9c8fb9e5d77fc36c09335e60daa9b3434e7..ee660a43960f16cb23359b3cfa8f0cf0d0419d8d 100644
--- a/mojo/services/ui/views/interfaces/view_associates.mojom
+++ b/mojo/services/ui/views/interfaces/view_associates.mojom
@@ -27,11 +27,6 @@ import "mojo/services/ui/views/interfaces/view_tree_token.mojom";
// This mechanism is designed to avoid a potential explosion in complexity
// if all features which depend on the state of views were implemented
// in one place.
-//
-// TODO(jeffbrown): In the current implementation, the view manager binds
-// to a hard coded set of associates at start up time which can be overridden
-// from the command-line. We should find a better way to register associates
-// once we decide how the system as a whole should be initialized.
[ServiceName="mojo::ui::ViewAssociate"]
interface ViewAssociate {
// Connects to the associate.
@@ -65,6 +60,9 @@ interface ViewAssociate {
handle<message_pipe> pipe);
};
+[ServiceName="mojo::ui::ViewAssociateOwner"]
jeffbrown 2016/05/18 18:07:16 Please add a comment explaining what this type rep
mikejurka 2016/05/18 19:09:10 Done.
+interface ViewAssociateOwner {};
+
// Provides information about the services offered by an associate.
struct ViewAssociateInfo {
// The names of view services offered by the associate.

Powered by Google App Engine
This is Rietveld 408576698