Issue 194923003: Move common methods to WebFormControlElement interface

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 194923003: Move common methods to WebFormControlElement interface (Closed)

Created:
6 years, 9 months ago by ziran.sun

Modified:
6 years, 9 months ago

Reviewers:
tkent, Ilya Sherman

CC:
blink-reviews, jamesr, dglazkov+blink, abarth-chromium

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

Move common methods to WebFormControlElement interface There are some common methods in Input element, TextArea element and Select element. By moving these methods to WebFormControlElement interface, it will simplify Chromium side code. R=isherman@chromium.org, tkent@chromium.org BUG=351255 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168923

Created: 6 years, 9 months ago

	Unified diffs	Side-by-side diffs	Stats (+91 lines, -102 lines)
M	Source/web/WebFormControlElement.cpp	View	4 chunks	+65 lines, -0 lines	0 comments
M	Source/web/WebInputElement.cpp	View	3 chunks	+0 lines, -35 lines	0 comments
M	Source/web/WebSelectElement.cpp	View	1 chunk	+0 lines, -10 lines	0 comments
M	Source/web/WebTextAreaElement.cpp	View	1 chunk	+0 lines, -35 lines	0 comments
M	public/web/WebFormControlElement.h	View	1 chunk	+26 lines, -3 lines	0 comments
M	public/web/WebInputElement.h	View	2 chunks	+0 lines, -9 lines	0 comments
M	public/web/WebSelectElement.h	View	1 chunk	+0 lines, -2 lines	0 comments
M	public/web/WebTextAreaElement.h	View	1 chunk	+0 lines, -8 lines	0 comments

Total messages: 4 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ziran.sun@samsung.com/194923003/1

6 years, 9 months ago (2014-03-11 13:37:07 UTC) #3

Message was sent while issue was closed.

Change committed as 168923