Disallow yield in computed property names of class expressions in params

Disallow yield in computed property names of class expressions in params

R=littledan@chromium.org
BUG=v8:4974
LOG=n

Committed: https://crrev.com/40b3626e450f6dcbcb610f5fab4a2028e51e3923
Cr-Commit-Position: refs/heads/master@{#36047}

[Dan Ehrenberg, 2016-05-04 22:36:34]

lgtm

https://codereview.chromium.org/1949223002/diff/1/test/cctest/test-parsing.cc
File test/cctest/test-parsing.cc (right):

https://codereview.chromium.org/1949223002/diff/1/test/cctest/test-parsing.cc...
test/cctest/test-parsing.cc:6785: "x = class { static [yield]() { } }",
Could you add a test which requires deeper recursion to get to, e.g., x = class
{ static [yield, 1]() { } }? Should work fine with our expression classifier,
just thinking about future refactorings.

[adamk, 2016-05-04 22:40:39]

Thanks for the quick review!

https://codereview.chromium.org/1949223002/diff/1/test/cctest/test-parsing.cc
File test/cctest/test-parsing.cc (right):

https://codereview.chromium.org/1949223002/diff/1/test/cctest/test-parsing.cc...
test/cctest/test-parsing.cc:6785: "x = class { static [yield]() { } }",
On 2016/05/04 22:36:34, Dan Ehrenberg wrote:
> Could you add a test which requires deeper recursion to get to, e.g., x =
class
> { static [yield, 1]() { } }? Should work fine with our expression classifier,
> just thinking about future refactorings.

Done.

[adamk, 2016-05-04 22:40:42]

The CQ bit was checked by adamk@chromium.org

[adamk, 2016-05-04 22:40:43]

The patchset sent to the CQ was uploaded after l-g-t-m from
littledan@chromium.org
Link to the patchset: https://codereview.chromium.org/1949223002/#ps20001
(title: "Added a few more tests")

[commit-bot: I haz the power, 2016-05-04 22:40:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1949223002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1949223002/20001

[commit-bot: I haz the power, 2016-05-04 23:24:13]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-04 23:25:36]

Description was changed from

==========
Disallow yield in computed property names of class expressions in params

R=littledan@chromium.org
BUG=v8:4974
LOG=n
==========

to

==========
Disallow yield in computed property names of class expressions in params

R=littledan@chromium.org
BUG=v8:4974
LOG=n

Committed: https://crrev.com/40b3626e450f6dcbcb610f5fab4a2028e51e3923
Cr-Commit-Position: refs/heads/master@{#36047}
==========

[commit-bot: I haz the power, 2016-05-04 23:25:37]

Patchset 2 (id:??) landed as
https://crrev.com/40b3626e450f6dcbcb610f5fab4a2028e51e3923
Cr-Commit-Position: refs/heads/master@{#36047}