Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Unified Diff: content/browser/frame_host/navigation_controller_impl.cc

Issue 1949213002: Don't update subframes on parent frame commits. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/frame_host/navigation_controller_impl_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/frame_host/navigation_controller_impl.cc
diff --git a/content/browser/frame_host/navigation_controller_impl.cc b/content/browser/frame_host/navigation_controller_impl.cc
index 7446d5153b845270ae510ff358d4c2fb960cf9e4..3c729f87027f867be24f7230ce6c15141a48f961 100644
--- a/content/browser/frame_host/navigation_controller_impl.cc
+++ b/content/browser/frame_host/navigation_controller_impl.cc
@@ -1878,6 +1878,21 @@ void NavigationControllerImpl::FindFramesToNavigate(
new_item->document_sequence_number() ==
old_item->document_sequence_number()) {
same_document_loads->push_back(std::make_pair(frame, new_item));
+
+ // TODO(avi, creis): This is a bug; we should not return here. Rather, we
+ // should continue on and navigate all child frames which have also
+ // changed. This bug is the cause of <https://crbug.com/542299>, which is
+ // a NC_IN_PAGE_NAVIGATION renderer kill.
+ //
+ // However, this bug is a bandaid over a deeper and worse problem. Doing a
+ // pushState immediately after loading a subframe is a race, one that no
+ // web page author expects. If we fix this bug, many large websites break.
+ // For example, see <https://crbug.com/598043> and the spec discussion at
+ // <https://github.com/whatwg/html/issues/1191>.
+ //
+ // For now, we accept this bug, and hope to resolve the race in a
+ // different way that will one day allow us to fix this.
+ return;
} else {
different_document_loads->push_back(std::make_pair(frame, new_item));
// For a different document, the subframes will be destroyed, so there's
« no previous file with comments | « no previous file | content/browser/frame_host/navigation_controller_impl_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698