Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1670)

Unified Diff: content/renderer/history_controller.cc

Issue 1949213002: Don't update subframes on parent frame commits. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/history_controller.cc
diff --git a/content/renderer/history_controller.cc b/content/renderer/history_controller.cc
index 5de3172d79d57301de45d093d4d6f45d28865a78..ce4f09472d106646cbd28792211a6e9a730bc279 100644
--- a/content/renderer/history_controller.cc
+++ b/content/renderer/history_controller.cc
@@ -146,6 +146,10 @@ void HistoryController::RecursiveGoToEntry(
new_item.documentSequenceNumber() ==
old_item.documentSequenceNumber()) {
same_document_loads.push_back(std::make_pair(frame, new_item));
+ // Returning here (and omitting child frames which have also changed) is
+ // wrong, but not returning here is worse. See the discussion in
+ // NavigationControllerImpl::FindFramesToNavigate for more information.
+ return;
} else {
different_document_loads.push_back(std::make_pair(frame, new_item));
// For a different document, the subframes will be destroyed, so there's

Powered by Google App Engine
This is Rietveld 408576698