content/renderer/pepper/host_globals.h - Issue 19492014: PPAPI: Purposely leak ProxyLock, fix shutdown race

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/pepper/host_globals.h

Issue 19492014: PPAPI: Purposely leak ProxyLock, fix shutdown race (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: test cleanup Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/pepper/host_globals.h

diff --git a/content/renderer/pepper/host_globals.h b/content/renderer/pepper/host_globals.h

index f48eb050d6c98c4c570541adf7042e0cb85af4b8..b90a8ec13b22ee86a13b56f5a29eacf0c13d366a 100644

--- a/content/renderer/pepper/host_globals.h

+++ b/content/renderer/pepper/host_globals.h

@@ -20,7 +20,6 @@ class PluginModule;

class HostGlobals : public ::ppapi::PpapiGlobals {

public:

HostGlobals();

- explicit HostGlobals(::ppapi::PpapiGlobals::PerThreadForTest);

virtual ~HostGlobals();

// Getter for the global singleton. Generally, you should use

@@ -43,7 +42,6 @@ class HostGlobals : public ::ppapi::PpapiGlobals {

virtual PP_Module GetModuleForInstance(PP_Instance instance) OVERRIDE;

virtual std::string GetCmdLine() OVERRIDE;

virtual void PreCacheFontForFlash(const void* logfontw) OVERRIDE;

- virtual base::Lock* GetProxyLock() OVERRIDE;

virtual void LogWithSource(PP_Instance instance,

PP_LogLevel level,

const std::string& source,