Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(766)

Unified Diff: ppapi/shared_impl/test_globals.h

Issue 19492014: PPAPI: Purposely leak ProxyLock, fix shutdown race (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Make the destructor lock [sometimes] Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ppapi/shared_impl/test_globals.h
diff --git a/ppapi/shared_impl/test_globals.h b/ppapi/shared_impl/test_globals.h
index 082af34b26c2de457cca0c9f2fb0d82351bfff6a..c2780c3fa418ec1e96c33070a7f14955314493b3 100644
--- a/ppapi/shared_impl/test_globals.h
+++ b/ppapi/shared_impl/test_globals.h
@@ -49,6 +49,8 @@ class TestGlobals : public PpapiGlobals {
explicit TestGlobals(PpapiGlobals::PerThreadForTest);
virtual ~TestGlobals();
+ void set_proxy_lock(base::Lock* lock) { lock_ = lock; }
+
// PpapiGlobals implementation.
virtual ResourceTracker* GetResourceTracker() OVERRIDE;
virtual VarTracker* GetVarTracker() OVERRIDE;
@@ -80,6 +82,7 @@ class TestGlobals : public PpapiGlobals {
ResourceTracker resource_tracker_;
TestVarTracker var_tracker_;
scoped_refptr<CallbackTracker> callback_tracker_;
+ base::Lock* lock_;
DISALLOW_COPY_AND_ASSIGN(TestGlobals);
};

Powered by Google App Engine
This is Rietveld 408576698