ppapi/proxy/ppb_core_proxy.cc - Issue 19492014: PPAPI: Purposely leak ProxyLock, fix shutdown race

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ppapi/proxy/ppb_core_proxy.cc

Issue 19492014: PPAPI: Purposely leak ProxyLock, fix shutdown race (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Make the destructor lock [sometimes] Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ppapi/proxy/ppb_core_proxy.cc

diff --git a/ppapi/proxy/ppb_core_proxy.cc b/ppapi/proxy/ppb_core_proxy.cc

index 1cc9671c4f28ed031c46cfaeee40ebe232d9f525..96aa9a4d573cec4e22696188744f674c141b4c45 100644

--- a/ppapi/proxy/ppb_core_proxy.cc

+++ b/ppapi/proxy/ppb_core_proxy.cc

@@ -62,6 +62,8 @@ void CallOnMainThread(int delay_in_ms,

#endif

if (!callback.func)

return;

+ ProxyAutoLock lock;

PpapiGlobals::Get()->GetMainThreadMessageLoop()->PostDelayedTask(

FROM_HERE,

RunWhileLocked(base::Bind(&CallbackWrapper, callback, result)),