ppapi/shared_impl/proxy_lock.cc - Issue 19492014: PPAPI: Purposely leak ProxyLock, fix shutdown race

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ppapi/shared_impl/proxy_lock.cc

Issue 19492014: PPAPI: Purposely leak ProxyLock, fix shutdown race (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Review comments Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "ppapi/shared_impl/proxy_lock.h"	5 #include "ppapi/shared_impl/proxy_lock.h"

6	6

7 #include "base/lazy_instance.h"	7 #include "base/lazy_instance.h"

8 #include "base/synchronization/lock.h"	8 #include "base/synchronization/lock.h"

9 #include "base/threading/thread_local.h"	9 #include "base/threading/thread_local.h"

10 #include "ppapi/shared_impl/ppapi_globals.h"	10 #include "ppapi/shared_impl/ppapi_globals.h"

(...skipping 41 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
52	52

53 lock->AssertAcquired();	53 lock->AssertAcquired();

54 }	54 }

55 }	55 }

56	56

57 void CallWhileUnlocked(const base::Closure& closure) {	57 void CallWhileUnlocked(const base::Closure& closure) {

58 ProxyAutoUnlock lock;	58 ProxyAutoUnlock lock;

59 closure.Run();	59 closure.Run();

60 }	60 }

61	61

62 void CallWhileLocked(const base::Closure& closure) {

63 ProxyAutoLock lock;

64 closure.Run();

65 }

66

67 } // namespace ppapi	62 } // namespace ppapi

OLD	NEW