Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Side by Side Diff: src/code-stubs-hydrogen.cc

Issue 19492007: Generate KeyedLoadDictionaryElementStub with Hydrogen (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Better formatting Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/code-stubs.cc ('k') | src/codegen.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1285 matching lines...) Expand 10 before | Expand all | Expand 10 after
1296 1296
1297 return js_function; 1297 return js_function;
1298 } 1298 }
1299 1299
1300 1300
1301 Handle<Code> FastNewClosureStub::GenerateCode(Isolate* isolate) { 1301 Handle<Code> FastNewClosureStub::GenerateCode(Isolate* isolate) {
1302 return DoGenerateCode(isolate, this); 1302 return DoGenerateCode(isolate, this);
1303 } 1303 }
1304 1304
1305 1305
1306 template <>
1307 class CodeStubGraphBuilder<KeyedLoadDictionaryElementStub>
1308 : public CodeStubGraphBuilderBase {
1309 public:
1310 explicit CodeStubGraphBuilder(Isolate* isolate,
1311 KeyedLoadDictionaryElementStub* stub)
1312 : CodeStubGraphBuilderBase(isolate, stub) {}
1313
1314 protected:
1315 HValue* BuildCodeStubHelper(HValue* dictionary,
1316 HValue* key,
1317 HValue* hash,
1318 HValue* mask,
1319 int current_probe);
1320
1321 virtual HValue* BuildCodeStub();
1322
1323 KeyedLoadDictionaryElementStub* casted_stub() {
1324 return static_cast<KeyedLoadDictionaryElementStub*>(stub());
1325 }
1326 };
1327
1328
1329 HValue* CodeStubGraphBuilder<KeyedLoadDictionaryElementStub>::
1330 BuildCodeStubHelper(
1331 HValue* elements,
1332 HValue* key,
1333 HValue* hash,
1334 HValue* mask,
1335 int current_probe) {
1336 if (current_probe == kNumberDictionaryProbes) {
1337 return NULL;
1338 }
1339
1340 int32_t offset = SeededNumberDictionary::GetProbeOffset(current_probe);
1341 HValue* raw_index = (current_probe == 0)
1342 ? hash
1343 : Add<HAdd>(hash, Add<HConstant>(offset));
1344 raw_index = Add<HBitwise>(Token::BIT_AND, raw_index, mask);
1345 int32_t entry_size = SeededNumberDictionary::kEntrySize;
1346 raw_index = Add<HMul>(raw_index, Add<HConstant>(entry_size));
1347 raw_index->ClearFlag(HValue::kCanOverflow);
1348
1349 int32_t base_offset = SeededNumberDictionary::kElementsStartIndex;
1350 HValue* key_index = Add<HAdd>(raw_index, Add<HConstant>(base_offset));
1351 key_index->ClearFlag(HValue::kCanOverflow);
1352
1353 HValue* candidate_key = Add<HLoadKeyed>(elements, key_index,
1354 static_cast<HValue*>(NULL),
1355 FAST_SMI_ELEMENTS);
1356
1357 IfBuilder key_compare(this);
1358 key_compare.IfNot<HCompareObjectEqAndBranch>(key, candidate_key);
1359 key_compare.Then();
1360 {
1361 // Key at the current probe doesn't match, try at the next probe.
1362 HValue* result = BuildCodeStubHelper(elements, key, hash, mask,
1363 current_probe + 1);
1364 if (result == NULL) {
1365 key_compare.Deopt("probes exhausted in keyed load dictionary lookup");
1366 result = graph()->GetConstantUndefined();
1367 } else {
1368 Push(result);
1369 }
1370 }
1371 key_compare.Else();
1372 {
1373 // Key at current probe matches. Details must be zero, otherwise the
1374 // dictionary element requires special handling.
1375 HValue* details_index = Add<HAdd>(raw_index,
1376 Add<HConstant>(base_offset + 2));
1377 details_index->ClearFlag(HValue::kCanOverflow);
1378
1379 HValue* details = Add<HLoadKeyed>(elements, details_index,
1380 static_cast<HValue*>(NULL),
1381 FAST_SMI_ELEMENTS);
1382 IfBuilder details_compare(this);
1383 details_compare.If<HCompareNumericAndBranch>(details,
1384 graph()->GetConstant0(),
1385 Token::NE);
1386 details_compare.ThenDeopt("keyed load dictionary element not fast case");
1387
1388 details_compare.Else();
1389 {
1390 // Key matches and details are zero --> fast case. Load and return the
1391 // value.
1392 HValue* result_index = Add<HAdd>(raw_index,
1393 Add<HConstant>(base_offset + 1));
1394 result_index->ClearFlag(HValue::kCanOverflow);
1395
1396 Push(Add<HLoadKeyed>(elements, result_index,
1397 static_cast<HValue*>(NULL),
1398 FAST_ELEMENTS));
1399 }
1400 details_compare.End();
1401 }
1402 key_compare.End();
1403
1404 return Pop();
1405 }
1406
1407
1408 HValue* CodeStubGraphBuilder<KeyedLoadDictionaryElementStub>::BuildCodeStub() {
1409 KeyedLoadDictionaryElementStub* stub = casted_stub();
1410
1411 HValue* dictionary = GetParameter(0);
1412 HValue* key = GetParameter(1);
1413 USE(stub);
1414 USE(dictionary);
1415
1416 HValue* elements = AddLoadElements(dictionary);
1417
1418 Add<HCheckSmi>(key);
1419
1420 HValue* hash = BuildElementIndexHash(key);
1421
1422 HValue* capacity = Add<HLoadKeyed>(
1423 elements,
1424 Add<HConstant>(NameDictionary::kCapacityIndex),
1425 static_cast<HValue*>(NULL),
1426 FAST_SMI_ELEMENTS);
1427
1428 HValue* mask = Add<HSub>(capacity, graph()->GetConstant1());
1429 mask->ChangeRepresentation(Representation::Integer32());
1430 mask->ClearFlag(HValue::kCanOverflow);
1431
1432 return BuildCodeStubHelper(elements, key, hash, mask, 0);
1433 }
1434
1435
1436 Handle<Code> KeyedLoadDictionaryElementStub::GenerateCode(Isolate* isolate) {
1437 return DoGenerateCode(isolate, this);
1438 }
1439
1440
1306 } } // namespace v8::internal 1441 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/code-stubs.cc ('k') | src/codegen.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698