Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(610)

Side by Side Diff: src/mips/code-stubs-mips.h

Issue 19492006: Cleanup StringAddFlags. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Add extra ASSERTs. Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ia32/full-codegen-ia32.cc ('k') | src/mips/code-stubs-mips.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 127 matching lines...) Expand 10 before | Expand all | Expand 10 after
138 Register character); 138 Register character);
139 139
140 static void GenerateHashGetHash(MacroAssembler* masm, 140 static void GenerateHashGetHash(MacroAssembler* masm,
141 Register hash); 141 Register hash);
142 142
143 private: 143 private:
144 DISALLOW_IMPLICIT_CONSTRUCTORS(StringHelper); 144 DISALLOW_IMPLICIT_CONSTRUCTORS(StringHelper);
145 }; 145 };
146 146
147 147
148 // Flag that indicates how to generate code for the stub StringAddStub.
149 enum StringAddFlags {
150 NO_STRING_ADD_FLAGS = 1 << 0,
151 // Omit left string check in stub (left is definitely a string).
152 NO_STRING_CHECK_LEFT_IN_STUB = 1 << 1,
153 // Omit right string check in stub (right is definitely a string).
154 NO_STRING_CHECK_RIGHT_IN_STUB = 1 << 2,
155 // Stub needs a frame before calling the runtime
156 ERECT_FRAME = 1 << 3,
157 // Omit both string checks in stub.
158 NO_STRING_CHECK_IN_STUB =
159 NO_STRING_CHECK_LEFT_IN_STUB | NO_STRING_CHECK_RIGHT_IN_STUB
160 };
161
162
163 class StringAddStub: public PlatformCodeStub { 148 class StringAddStub: public PlatformCodeStub {
164 public: 149 public:
165 explicit StringAddStub(StringAddFlags flags) : flags_(flags) {} 150 explicit StringAddStub(StringAddFlags flags) : flags_(flags) {}
166 151
167 private: 152 private:
168 Major MajorKey() { return StringAdd; } 153 Major MajorKey() { return StringAdd; }
169 int MinorKey() { return flags_; } 154 int MinorKey() { return flags_; }
170 155
171 void Generate(MacroAssembler* masm); 156 void Generate(MacroAssembler* masm);
172 157
(...skipping 529 matching lines...) Expand 10 before | Expand all | Expand 10 after
702 687
703 class LookupModeBits: public BitField<LookupMode, 0, 1> {}; 688 class LookupModeBits: public BitField<LookupMode, 0, 1> {};
704 689
705 LookupMode mode_; 690 LookupMode mode_;
706 }; 691 };
707 692
708 693
709 } } // namespace v8::internal 694 } } // namespace v8::internal
710 695
711 #endif // V8_MIPS_CODE_STUBS_ARM_H_ 696 #endif // V8_MIPS_CODE_STUBS_ARM_H_
OLDNEW
« no previous file with comments | « src/ia32/full-codegen-ia32.cc ('k') | src/mips/code-stubs-mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698