Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Side by Side Diff: src/ia32/code-stubs-ia32.h

Issue 19492006: Cleanup StringAddFlags. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Add extra ASSERTs. Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/hydrogen-instructions.h ('k') | src/ia32/code-stubs-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 126 matching lines...) Expand 10 before | Expand all | Expand 10 after
137 Register scratch); 137 Register scratch);
138 static void GenerateHashGetHash(MacroAssembler* masm, 138 static void GenerateHashGetHash(MacroAssembler* masm,
139 Register hash, 139 Register hash,
140 Register scratch); 140 Register scratch);
141 141
142 private: 142 private:
143 DISALLOW_IMPLICIT_CONSTRUCTORS(StringHelper); 143 DISALLOW_IMPLICIT_CONSTRUCTORS(StringHelper);
144 }; 144 };
145 145
146 146
147 enum StringAddFlags {
148 NO_STRING_ADD_FLAGS = 1 << 0,
149 // Omit left string check in stub (left is definitely a string).
150 NO_STRING_CHECK_LEFT_IN_STUB = 1 << 1,
151 // Omit right string check in stub (right is definitely a string).
152 NO_STRING_CHECK_RIGHT_IN_STUB = 1 << 2,
153 // Stub needs a frame before calling the runtime
154 ERECT_FRAME = 1 << 3,
155 // Omit both string checks in stub.
156 NO_STRING_CHECK_IN_STUB =
157 NO_STRING_CHECK_LEFT_IN_STUB | NO_STRING_CHECK_RIGHT_IN_STUB
158 };
159
160
161 class StringAddStub: public PlatformCodeStub { 147 class StringAddStub: public PlatformCodeStub {
162 public: 148 public:
163 explicit StringAddStub(StringAddFlags flags) : flags_(flags) {} 149 explicit StringAddStub(StringAddFlags flags) : flags_(flags) {}
164 150
165 private: 151 private:
166 Major MajorKey() { return StringAdd; } 152 Major MajorKey() { return StringAdd; }
167 int MinorKey() { return flags_; } 153 int MinorKey() { return flags_; }
168 154
169 void Generate(MacroAssembler* masm); 155 void Generate(MacroAssembler* masm);
170 156
(...skipping 402 matching lines...) Expand 10 before | Expand all | Expand 10 after
573 Register address_; 559 Register address_;
574 RememberedSetAction remembered_set_action_; 560 RememberedSetAction remembered_set_action_;
575 SaveFPRegsMode save_fp_regs_mode_; 561 SaveFPRegsMode save_fp_regs_mode_;
576 RegisterAllocation regs_; 562 RegisterAllocation regs_;
577 }; 563 };
578 564
579 565
580 } } // namespace v8::internal 566 } } // namespace v8::internal
581 567
582 #endif // V8_IA32_CODE_STUBS_IA32_H_ 568 #endif // V8_IA32_CODE_STUBS_IA32_H_
OLDNEW
« no previous file with comments | « src/hydrogen-instructions.h ('k') | src/ia32/code-stubs-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698