Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(436)

Side by Side Diff: src/code-stubs.h

Issue 19492006: Cleanup StringAddFlags. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Add extra ASSERTs. Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/full-codegen-arm.cc ('k') | src/hydrogen.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 375 matching lines...) Expand 10 before | Expand all | Expand 10 after
386 386
387 virtual void AfterCall(MacroAssembler* masm) const = 0; 387 virtual void AfterCall(MacroAssembler* masm) const = 0;
388 388
389 protected: 389 protected:
390 RuntimeCallHelper() {} 390 RuntimeCallHelper() {}
391 391
392 private: 392 private:
393 DISALLOW_COPY_AND_ASSIGN(RuntimeCallHelper); 393 DISALLOW_COPY_AND_ASSIGN(RuntimeCallHelper);
394 }; 394 };
395 395
396
397 // TODO(bmeurer): Move to the StringAddStub declaration once we're
398 // done with the translation to a hydrogen code stub.
399 enum StringAddFlags {
400 // Omit both parameter checks.
401 STRING_ADD_CHECK_NONE = 0,
402 // Check left parameter.
403 STRING_ADD_CHECK_LEFT = 1 << 0,
404 // Check right parameter.
405 STRING_ADD_CHECK_RIGHT = 1 << 1,
406 // Check both parameters.
407 STRING_ADD_CHECK_BOTH = STRING_ADD_CHECK_LEFT | STRING_ADD_CHECK_RIGHT,
408 // Stub needs a frame before calling the runtime
409 STRING_ADD_ERECT_FRAME = 1 << 2
410 };
411
396 } } // namespace v8::internal 412 } } // namespace v8::internal
397 413
398 #if V8_TARGET_ARCH_IA32 414 #if V8_TARGET_ARCH_IA32
399 #include "ia32/code-stubs-ia32.h" 415 #include "ia32/code-stubs-ia32.h"
400 #elif V8_TARGET_ARCH_X64 416 #elif V8_TARGET_ARCH_X64
401 #include "x64/code-stubs-x64.h" 417 #include "x64/code-stubs-x64.h"
402 #elif V8_TARGET_ARCH_ARM 418 #elif V8_TARGET_ARCH_ARM
403 #include "arm/code-stubs-arm.h" 419 #include "arm/code-stubs-arm.h"
404 #elif V8_TARGET_ARCH_MIPS 420 #elif V8_TARGET_ARCH_MIPS
405 #include "mips/code-stubs-mips.h" 421 #include "mips/code-stubs-mips.h"
(...skipping 1991 matching lines...) Expand 10 before | Expand all | Expand 10 after
2397 int MinorKey() { return 0; } 2413 int MinorKey() { return 0; }
2398 2414
2399 void Generate(MacroAssembler* masm); 2415 void Generate(MacroAssembler* masm);
2400 2416
2401 DISALLOW_COPY_AND_ASSIGN(ProfileEntryHookStub); 2417 DISALLOW_COPY_AND_ASSIGN(ProfileEntryHookStub);
2402 }; 2418 };
2403 2419
2404 } } // namespace v8::internal 2420 } } // namespace v8::internal
2405 2421
2406 #endif // V8_CODE_STUBS_H_ 2422 #endif // V8_CODE_STUBS_H_
OLDNEW
« no previous file with comments | « src/arm/full-codegen-arm.cc ('k') | src/hydrogen.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698