Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(961)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1949173002: Add three missing test files to the .gn builds (Closed)

Created:
4 years, 7 months ago by brucedawson
Modified:
4 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add three missing test files to the .gn builds BUG=604060 Committed: https://crrev.com/cf9b781660acfac6f0a13be66d868252d77588d4 Cr-Commit-Position: refs/heads/master@{#391806}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M google_apis/BUILD.gn View 3 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
brucedawson
These are in the gyp build but not in the gn build, which seems bad. ...
4 years, 7 months ago (2016-05-04 19:40:37 UTC) #2
Roger Tawa OOO till Jul 10th
lgtm
4 years, 7 months ago (2016-05-05 14:29:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1949173002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1949173002/1
4 years, 7 months ago (2016-05-05 14:33:13 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-05 15:26:49 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-05 15:29:05 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/cf9b781660acfac6f0a13be66d868252d77588d4
Cr-Commit-Position: refs/heads/master@{#391806}

Powered by Google App Engine
This is Rietveld 408576698