Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 1949163006: NTP - Add a histogram tracking the time to load offline content. (Closed)

Created:
4 years, 7 months ago by dewittj
Modified:
4 years, 7 months ago
CC:
chromium-reviews, mcwilliams+watch_chromium.org, asvitkine+watch_chromium.org, dgn+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

NTP - Add a histogram tracking the time to load offline content. This will be used to determine if a better UI is required while waiting for disk operations to complete. BUG=607573 Committed: https://crrev.com/a814ec0b9c16e31e664121ad948ae89070d96229 Cr-Commit-Position: refs/heads/master@{#392358}

Patch Set 1 #

Total comments: 2

Patch Set 2 : add units #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java View 2 chunks +6 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
dewittj
PTAL, thanks
4 years, 7 months ago (2016-05-06 16:12:16 UTC) #2
Alexei Svitkine (slow)
lgtm https://codereview.chromium.org/1949163006/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/1949163006/diff/1/tools/metrics/histograms/histograms.xml#newcode33100 tools/metrics/histograms/histograms.xml:33100: +<histogram name="NewTabPage.OfflineUrlsLoadTime"> Nit: units="ms"
4 years, 7 months ago (2016-05-06 19:54:17 UTC) #3
dewittj
https://codereview.chromium.org/1949163006/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/1949163006/diff/1/tools/metrics/histograms/histograms.xml#newcode33100 tools/metrics/histograms/histograms.xml:33100: +<histogram name="NewTabPage.OfflineUrlsLoadTime"> On 2016/05/06 19:54:16, Alexei Svitkine wrote: > ...
4 years, 7 months ago (2016-05-06 19:59:36 UTC) #4
Bernhard Bauer
lgtm
4 years, 7 months ago (2016-05-09 09:51:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1949163006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1949163006/20001
4 years, 7 months ago (2016-05-09 16:23:52 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-09 17:53:04 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-09 17:54:42 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a814ec0b9c16e31e664121ad948ae89070d96229
Cr-Commit-Position: refs/heads/master@{#392358}

Powered by Google App Engine
This is Rietveld 408576698