Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 1949163003: fix for #520, ListMixin should work again (Closed)

Created:
4 years, 7 months ago by Jennifer Messerly
Modified:
4 years, 7 months ago
Reviewers:
vsm
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

fix for #520, ListMixin should work again it regressed when dart:html was added and it became an "extension type" R=vsm@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/2b594db0bcbb1b0c0a44e573e2f6927095543899

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3522 lines, -2514 lines) Patch
M lib/runtime/dart_sdk.js View 203 chunks +3316 lines, -1743 lines 0 comments Download
M lib/src/compiler/code_generator.dart View 11 chunks +15 lines, -27 lines 0 comments Download
M lib/src/compiler/compiler.dart View 1 chunk +11 lines, -2 lines 0 comments Download
M lib/src/compiler/extension_types.dart View 1 chunk +162 lines, -737 lines 0 comments Download
M lib/src/compiler/js_field_storage.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/browser/language_tests.js View 1 3 chunks +1 line, -4 lines 0 comments Download
A test/codegen/language/list_mixin_test.dart View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Jennifer Messerly
4 years, 7 months ago (2016-05-04 20:55:18 UTC) #2
Jennifer Messerly
https://codereview.chromium.org/1949163003/diff/1/test/browser/language_tests.js File test/browser/language_tests.js (right): https://codereview.chromium.org/1949163003/diff/1/test/browser/language_tests.js#newcode442 test/browser/language_tests.js:442: 'string_fromcharcodes_test': skip_fail, // timeouts will change to: skip_timeout (just ...
4 years, 7 months ago (2016-05-04 20:58:08 UTC) #3
vsm
lgtm
4 years, 7 months ago (2016-05-04 21:20:24 UTC) #4
Jennifer Messerly
4 years, 7 months ago (2016-05-04 21:31:34 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
2b594db0bcbb1b0c0a44e573e2f6927095543899 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698