Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 1949153003: Do V8 GC ASAP if system memory is pressured[reland] (Closed)

Created:
4 years, 7 months ago by hong.zheng
Modified:
4 years, 7 months ago
CC:
blink-reviews, blink-reviews-api_chromium.org, blink-worker-reviews_chromium.org, chromium-reviews, darin-cc_chromium.org, dglazkov+blink, falken, gavinp+memory_chromium.org, horo+watch_chromium.org, jam, kinuko+worker_chromium.org, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Do V8 GC ASAP if system memory is pressured[reland] Remove worker thread isolate before V8PerIsolateData::destroy This is a reland of https://codereview.chromium.org/1749073002/ BUG=590975 Committed: https://crrev.com/b28b53323cf9a4e487e081a63b546c210f4878b2 Cr-Commit-Position: refs/heads/master@{#392833}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+163 lines, -49 lines) Patch
M base/memory/memory_pressure_listener.h View 2 chunks +12 lines, -5 lines 0 comments Download
M base/memory/memory_pressure_listener.cc View 3 chunks +58 lines, -22 lines 0 comments Download
M content/renderer/render_thread_impl.h View 1 chunk +3 lines, -0 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 7 chunks +35 lines, -22 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerBackingThread.h View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerBackingThread.cpp View 3 chunks +39 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebKit.cpp View 2 chunks +8 lines, -0 lines 0 comments Download
M third_party/WebKit/public/web/WebKit.h View 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
hong.zheng
PTAL
4 years, 7 months ago (2016-05-05 10:38:20 UTC) #2
petefranklin672
lgtm
4 years, 7 months ago (2016-05-05 10:49:21 UTC) #4
jochen (gone - plz use gerrit)
lgtm
4 years, 7 months ago (2016-05-06 09:49:45 UTC) #5
hong.zheng
kinuko@, the difference between the CL and CL 1749073002 is that the CL moves removeWorkerIsolate ...
4 years, 7 months ago (2016-05-09 02:01:45 UTC) #6
kinuko
lgtm
4 years, 7 months ago (2016-05-09 08:29:50 UTC) #7
hong.zheng
esprehn@ and mark@, PTAL. Thanks
4 years, 7 months ago (2016-05-09 09:55:01 UTC) #8
Mark Mentovai
This looks like the same in base as https://codereview.chromium.org/1749073002/, so LGTM
4 years, 7 months ago (2016-05-09 15:14:45 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1949153003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1949153003/1
4 years, 7 months ago (2016-05-11 01:07:34 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-11 02:33:53 UTC) #12
commit-bot: I haz the power
4 years, 7 months ago (2016-05-11 02:35:28 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b28b53323cf9a4e487e081a63b546c210f4878b2
Cr-Commit-Position: refs/heads/master@{#392833}

Powered by Google App Engine
This is Rietveld 408576698