Added pretty printers for some Ink Drop enums.

Added pretty printers for some Ink Drop enums.

The default strings output by GTest for enums in failed EXPECT/ASSERT macros are
of the format "4-byte object <01-00 00-00>" which aren't very readable.

BUG=None

Committed: https://crrev.com/6837db98420c5f69b96d8f56e0c61fb121f516cc
Cr-Commit-Position: refs/heads/master@{#391722}

[bruthig, 2016-05-04 22:33:29]

bruthig@chromium.org changed reviewers:
+ sky@chromium.org

[bruthig, 2016-05-04 22:33:30]

sky@, can you PTAL?

[sky, 2016-05-04 23:43:42]

LGTM with the const&

https://codereview.chromium.org/1949143003/diff/1/ui/views/animation/ink_drop...
File ui/views/animation/ink_drop_animation_ended_reason.h (right):

https://codereview.chromium.org/1949143003/diff/1/ui/views/animation/ink_drop...
ui/views/animation/ink_drop_animation_ended_reason.h:24: VIEWS_EXPORT
std::string ToString(const InkDropAnimationEndedReason& reason);
Generally we don't pass primitives by ref. For example, when was the last time
you saw a function take a const int&?

https://codereview.chromium.org/1949143003/diff/1/ui/views/animation/ink_drop...
ui/views/animation/ink_drop_animation_ended_reason.h:29: void PrintTo(const
InkDropAnimationEndedReason& reason, ::std::ostream* os);
and here

https://codereview.chromium.org/1949143003/diff/1/ui/views/animation/ink_drop...
File ui/views/animation/ink_drop_hover.h (right):

https://codereview.chromium.org/1949143003/diff/1/ui/views/animation/ink_drop...
ui/views/animation/ink_drop_hover.h:119: const InkDropHover::AnimationType&
animation_type);
Same comment here.

https://codereview.chromium.org/1949143003/diff/1/ui/views/animation/ink_drop...
ui/views/animation/ink_drop_hover.h:124: void PrintTo(const
InkDropHover::AnimationType& animation_type,
and here.

https://codereview.chromium.org/1949143003/diff/1/ui/views/animation/ink_drop...
File ui/views/animation/ink_drop_state.h (right):

https://codereview.chromium.org/1949143003/diff/1/ui/views/animation/ink_drop...
ui/views/animation/ink_drop_state.h:40: VIEWS_EXPORT std::string ToString(const
InkDropState& state);
And in this file.

[bruthig, 2016-05-04 23:51:48]

Fixed nits, no need to review.

https://codereview.chromium.org/1949143003/diff/1/ui/views/animation/ink_drop...
File ui/views/animation/ink_drop_animation_ended_reason.h (right):

https://codereview.chromium.org/1949143003/diff/1/ui/views/animation/ink_drop...
ui/views/animation/ink_drop_animation_ended_reason.h:24: VIEWS_EXPORT
std::string ToString(const InkDropAnimationEndedReason& reason);
On 2016/05/04 23:43:42, sky wrote:
> Generally we don't pass primitives by ref. For example, when was the last time
> you saw a function take a const int&?

Done.

https://codereview.chromium.org/1949143003/diff/1/ui/views/animation/ink_drop...
ui/views/animation/ink_drop_animation_ended_reason.h:29: void PrintTo(const
InkDropAnimationEndedReason& reason, ::std::ostream* os);
On 2016/05/04 23:43:42, sky wrote:
> and here

Done.

https://codereview.chromium.org/1949143003/diff/1/ui/views/animation/ink_drop...
File ui/views/animation/ink_drop_hover.h (right):

https://codereview.chromium.org/1949143003/diff/1/ui/views/animation/ink_drop...
ui/views/animation/ink_drop_hover.h:119: const InkDropHover::AnimationType&
animation_type);
On 2016/05/04 23:43:42, sky wrote:
> Same comment here.

Done.

https://codereview.chromium.org/1949143003/diff/1/ui/views/animation/ink_drop...
ui/views/animation/ink_drop_hover.h:124: void PrintTo(const
InkDropHover::AnimationType& animation_type,
On 2016/05/04 23:43:42, sky wrote:
> and here.

Done.

https://codereview.chromium.org/1949143003/diff/1/ui/views/animation/ink_drop...
File ui/views/animation/ink_drop_state.h (right):

https://codereview.chromium.org/1949143003/diff/1/ui/views/animation/ink_drop...
ui/views/animation/ink_drop_state.h:40: VIEWS_EXPORT std::string ToString(const
InkDropState& state);
On 2016/05/04 23:43:42, sky wrote:
> And in this file.

Done.

[bruthig, 2016-05-04 23:51:53]

The CQ bit was checked by bruthig@chromium.org

[bruthig, 2016-05-04 23:51:54]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1949143003/#ps20001
(title: "Removed primitive pass by refs.")

[commit-bot: I haz the power, 2016-05-04 23:52:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1949143003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1949143003/20001

[commit-bot: I haz the power, 2016-05-05 00:58:26]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-05 00:59:30]

Description was changed from

==========
Added pretty printers for some Ink Drop enums.

The default strings output by GTest for enums in failed EXPECT/ASSERT macros are
of the format "4-byte object <01-00 00-00>" which aren't very readable.

BUG=None
==========

to

==========
Added pretty printers for some Ink Drop enums.

The default strings output by GTest for enums in failed EXPECT/ASSERT macros are
of the format "4-byte object <01-00 00-00>" which aren't very readable.

BUG=None

Committed: https://crrev.com/6837db98420c5f69b96d8f56e0c61fb121f516cc
Cr-Commit-Position: refs/heads/master@{#391722}
==========

[commit-bot: I haz the power, 2016-05-05 00:59:31]

Patchset 2 (id:??) landed as
https://crrev.com/6837db98420c5f69b96d8f56e0c61fb121f516cc
Cr-Commit-Position: refs/heads/master@{#391722}