Fixing an It2Me host crash on debug builds on Windows

Fixing an It2Me host crash on debug builds on Windows

While working on an different It2Me work item I noticed that every time I tried
to connect the host would crash with an error: "Function marked as IO-only was
called from a thread that disallows IO!...".

After some investigation I found that the It2Me host attempts to create the
TouchInputInjector (which loads a DLL) on its network thread causing the DCHECK
crash.  The Me2Me host creates this object on its UI thread which is also where
the injector is initialized so my fix is to move the creation of the
TouchInputInjector to the UI thread as well so we can guarantee it does not
occur on an invalid thread.

BUG=609639
Committed: https://crrev.com/afc2dfda52924730d7d1b59eb4340fbeabdc8150
Cr-Commit-Position: refs/heads/master@{#392117}

[joedow, 2016-05-05 23:13:02]

Description was changed from

==========
Fixing an It2Me host crash on debug builds on Windows

While working on an different It2Me work item I noticed that every time I tried
to connect the host would crash with an error: "Function marked as IO-only was
called from a thread that disallows IO!...".

After some investigation I found that the It2Me host attempts to create the
TouchInputInjector on its network thread (The Me2Me host creates this object on
its UI thread).  My fix is to move the creation of the TouchInputInjector to
the UI thread.

BUG=609639
==========

to

==========
Fixing an It2Me host crash on debug builds on Windows

While working on an different It2Me work item I noticed that every time I tried
to connect the host would crash with an error: "Function marked as IO-only was
called from a thread that disallows IO!...".

After some investigation I found that the It2Me host attempts to create the
TouchInputInjector (which loads a DLL) on its network thread causing the DCHECK
crash.  The Me2Me host creates this object on its UI thread which is also where
the injector is initialized so my fix is to move the creation of the
TouchInputInjector to the UI thread as well so we can guarantee it does not
occur on an invalid thread.

BUG=609639
==========

[joedow, 2016-05-05 23:55:54]

joedow@chromium.org changed reviewers:
+ jamiewalch@chromium.org

[joedow, 2016-05-05 23:55:55]

PTAL!

Thanks,
Joe

[Jamie, 2016-05-06 17:22:02]

LGTM.

Does this need to be merged for another M51 release?

[joedow, 2016-05-06 19:15:07]

I tested out M51 release and we are good.  I have a feeling (based on inspection
and discussions) that this has been around for a while and only applies to debug
builds.

[joedow, 2016-05-06 19:15:16]

The CQ bit was checked by joedow@chromium.org

[commit-bot: I haz the power, 2016-05-06 19:15:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1949113005/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1949113005/1

[commit-bot: I haz the power, 2016-05-06 19:19:47]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-05-06 19:22:01]

Description was changed from

==========
Fixing an It2Me host crash on debug builds on Windows

While working on an different It2Me work item I noticed that every time I tried
to connect the host would crash with an error: "Function marked as IO-only was
called from a thread that disallows IO!...".

After some investigation I found that the It2Me host attempts to create the
TouchInputInjector (which loads a DLL) on its network thread causing the DCHECK
crash.  The Me2Me host creates this object on its UI thread which is also where
the injector is initialized so my fix is to move the creation of the
TouchInputInjector to the UI thread as well so we can guarantee it does not
occur on an invalid thread.

BUG=609639
==========

to

==========
Fixing an It2Me host crash on debug builds on Windows

While working on an different It2Me work item I noticed that every time I tried
to connect the host would crash with an error: "Function marked as IO-only was
called from a thread that disallows IO!...".

After some investigation I found that the It2Me host attempts to create the
TouchInputInjector (which loads a DLL) on its network thread causing the DCHECK
crash.  The Me2Me host creates this object on its UI thread which is also where
the injector is initialized so my fix is to move the creation of the
TouchInputInjector to the UI thread as well so we can guarantee it does not
occur on an invalid thread.

BUG=609639

Committed: https://crrev.com/afc2dfda52924730d7d1b59eb4340fbeabdc8150
Cr-Commit-Position: refs/heads/master@{#392117}
==========

[commit-bot: I haz the power, 2016-05-06 19:22:02]

Patchset 1 (id:??) landed as
https://crrev.com/afc2dfda52924730d7d1b59eb4340fbeabdc8150
Cr-Commit-Position: refs/heads/master@{#392117}