Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1949113003: Removes unnecessary function in WmWindow (Closed)

Created:
4 years, 7 months ago by sky
Modified:
4 years, 7 months ago
Reviewers:
James Cook
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removes unnecessary function in WmWindow This become unnecessary at some point, but was never removed. BUG=603369 TEST=covered by tests R=jamescook@chromium.org Committed: https://crrev.com/2cd4549a5a5e04deffc3780ecc52d52b0ea685f0 Cr-Commit-Position: refs/heads/master@{#391704}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M ash/wm/aura/wm_window_aura.h View 1 chunk +0 lines, -1 line 0 comments Download
M ash/wm/aura/wm_window_aura.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M ash/wm/common/wm_window.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
sky
4 years, 7 months ago (2016-05-04 22:10:43 UTC) #1
James Cook
lgtm
4 years, 7 months ago (2016-05-04 23:55:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1949113003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1949113003/1
4 years, 7 months ago (2016-05-04 23:58:17 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-05 00:03:20 UTC) #5
commit-bot: I haz the power
4 years, 7 months ago (2016-05-05 00:04:46 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/2cd4549a5a5e04deffc3780ecc52d52b0ea685f0
Cr-Commit-Position: refs/heads/master@{#391704}

Powered by Google App Engine
This is Rietveld 408576698