Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 1949053002: Re-enable complex text path on android (Closed)

Created:
4 years, 7 months ago by eae
Modified:
4 years, 7 months ago
Reviewers:
drott
CC:
chromium-reviews, krit, pdr+graphicswatchlist_chromium.org, drott+blinkwatch_chromium.org, blink-reviews-platform-graphics_chromium.org, dshwang, jbroman, Justin Novosad, Rik, Stephen Chennney, blink-reviews, f(malita), danakj+watch_chromium.org, kinuko+watch, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-enable complex text path on android Trying to re-enable the complex text path on Android now that hb_font_t is cached with the user data container instead of the hb_face_t object. This should result in lower memory usage for the complex text code path, we'll watch the memory bots though and revert as needed if it regresses. BUG=577306 R=drott@chromium.org Committed: https://crrev.com/9af72a88ea5b39c2c36c99f8b091c5feae82ef7d Cr-Commit-Position: refs/heads/master@{#392010}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M third_party/WebKit/Source/platform/fonts/Font.cpp View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
eae
4 years, 7 months ago (2016-05-04 13:03:25 UTC) #1
eae
Must land after https://codereview.chromium.org/1943993003/
4 years, 7 months ago (2016-05-04 13:06:52 UTC) #2
drott
LGTM
4 years, 7 months ago (2016-05-04 13:36:47 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1949053002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1949053002/1
4 years, 7 months ago (2016-05-05 16:03:29 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-05 18:26:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1949053002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1949053002/1
4 years, 7 months ago (2016-05-06 05:46:30 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-06 05:50:11 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/9af72a88ea5b39c2c36c99f8b091c5feae82ef7d Cr-Commit-Position: refs/heads/master@{#392010}
4 years, 7 months ago (2016-05-06 05:51:17 UTC) #12
eae
4 years, 7 months ago (2016-05-09 15:32:18 UTC) #13
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1962703002/ by eae@chromium.org.

The reason for reverting is: Memory and perf regression

BUG=609940.

Powered by Google App Engine
This is Rietveld 408576698