Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 194903007: Convert most Chromium presubmit files to use new multiple-tryserver-compatible protocol (Closed)

Created:
6 years, 9 months ago by Paweł Hajdan Jr.
Modified:
6 years, 9 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews, sadrul, sievers+watch_chromium.org, Sam Clegg, tim+watch_chromium.org, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, jbauman+watch_chromium.org, timurrrr+watch_chromium.org, chromium-apps-reviews_chromium.org, erikwright+watch_chromium.org, bruening+watch_chromium.org, haitaol+watch_chromium.org, dmikurube+memory_chromium.org, kalyank, piman+watch_chromium.org, binji, maniscalco+watch_chromium.org, Ian Vollick, tfarina, danakj+watch_chromium.org, glider+watch_chromium.org, ben+ash_chromium.org
Visibility:
Public.

Description

Convert most Chromium presubmit files to use new multiple-tryserver-compatible protocol BUG=334892 R=maruel@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=256318

Patch Set 1 #

Total comments: 8

Patch Set 2 : setdefault #

Unified diffs Side-by-side diffs Delta from patch set Stats (+186 lines, -107 lines) Patch
M ash/PRESUBMIT.py View 1 chunk +6 lines, -2 lines 0 comments Download
M base/PRESUBMIT.py View 1 chunk +8 lines, -6 lines 0 comments Download
M chrome/browser/extensions/PRESUBMIT.py View 1 chunk +6 lines, -2 lines 0 comments Download
M chrome/browser/policy/PRESUBMIT.py View 1 chunk +7 lines, -5 lines 0 comments Download
M chrome/browser/sync/PRESUBMIT.py View 1 chunk +8 lines, -6 lines 0 comments Download
M chrome/browser/ui/libgtk2ui/PRESUBMIT.py View 1 chunk +6 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/PRESUBMIT.py View 1 chunk +6 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/PRESUBMIT.py View 1 chunk +6 lines, -2 lines 0 comments Download
M chrome/common/net/PRESUBMIT.py View 1 chunk +8 lines, -6 lines 0 comments Download
M crypto/PRESUBMIT.py View 1 chunk +6 lines, -3 lines 0 comments Download
M extensions/browser/PRESUBMIT.py View 1 chunk +6 lines, -2 lines 0 comments Download
M gpu/PRESUBMIT.py View 1 chunk +9 lines, -7 lines 0 comments Download
M jingle/PRESUBMIT.py View 1 chunk +8 lines, -6 lines 0 comments Download
M native_client_sdk/PRESUBMIT.py View 1 chunk +11 lines, -9 lines 0 comments Download
M net/PRESUBMIT.py View 1 1 chunk +11 lines, -8 lines 0 comments Download
M skia/PRESUBMIT.py View 1 chunk +10 lines, -8 lines 0 comments Download
M sync/PRESUBMIT.py View 1 chunk +8 lines, -6 lines 0 comments Download
M third_party/tcmalloc/PRESUBMIT.py View 1 chunk +6 lines, -2 lines 0 comments Download
M tools/lsan/PRESUBMIT.py View 1 chunk +6 lines, -2 lines 0 comments Download
M tools/valgrind/drmemory/PRESUBMIT.py View 1 chunk +6 lines, -2 lines 0 comments Download
M tools/valgrind/memcheck/PRESUBMIT.py View 1 chunk +7 lines, -2 lines 0 comments Download
M tools/valgrind/tsan/PRESUBMIT.py View 1 chunk +6 lines, -2 lines 0 comments Download
M ui/compositor/PRESUBMIT.py View 1 chunk +6 lines, -2 lines 0 comments Download
M ui/events/PRESUBMIT.py View 1 chunk +10 lines, -6 lines 0 comments Download
M ui/gl/PRESUBMIT.py View 1 chunk +9 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Paweł Hajdan Jr.
6 years, 9 months ago (2014-03-11 20:45:00 UTC) #1
M-A Ruel
lgtm anyhow. https://codereview.chromium.org/194903007/diff/1/base/PRESUBMIT.py File base/PRESUBMIT.py (right): https://codereview.chromium.org/194903007/diff/1/base/PRESUBMIT.py#newcode54 base/PRESUBMIT.py:54: 'linux_rel': set(['sync_integration_tests']), (FTR, this is weird) https://codereview.chromium.org/194903007/diff/1/net/PRESUBMIT.py ...
6 years, 9 months ago (2014-03-11 20:54:49 UTC) #2
Paweł Hajdan Jr.
https://codereview.chromium.org/194903007/diff/1/base/PRESUBMIT.py File base/PRESUBMIT.py (right): https://codereview.chromium.org/194903007/diff/1/base/PRESUBMIT.py#newcode54 base/PRESUBMIT.py:54: 'linux_rel': set(['sync_integration_tests']), On 2014/03/11 20:54:49, M-A Ruel wrote: > ...
6 years, 9 months ago (2014-03-11 21:25:41 UTC) #3
M-A Ruel
https://codereview.chromium.org/194903007/diff/1/base/PRESUBMIT.py File base/PRESUBMIT.py (right): https://codereview.chromium.org/194903007/diff/1/base/PRESUBMIT.py#newcode54 base/PRESUBMIT.py:54: 'linux_rel': set(['sync_integration_tests']), On 2014/03/11 21:25:41, Paweł Hajdan Jr. wrote: ...
6 years, 9 months ago (2014-03-11 21:31:01 UTC) #4
Paweł Hajdan Jr.
6 years, 9 months ago (2014-03-11 21:45:36 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 manually as r256318.

Powered by Google App Engine
This is Rietveld 408576698