Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issue 194903003: Revert of New version of the bbh shootout (Closed)

Created:
6 years, 9 months ago by hal.canary
Modified:
6 years, 9 months ago
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Revert of New version of the bbh shootout (https://codereview.chromium.org/186973005/) Reason for revert: breaking build on at least 12 configurations. Original issue's description: > New version of the bbh shootout. > There were a bunch of problems with the existing code, all of which I would of ignored, except it could only benchmark none and rtree. > The new version measures the same numbers, in almost exactly the same way, it's the structure over the top of the actual test runner that I changed. > Now it only loads the pictures once, it is configurable in which bbh's it runs and how may loops on them it does, it uses standard command line processing, and it does not do so much redundant work so it runs quicker. It is also much easier to understand and change IMHO. > > Doing this so I can reasonably compare the new QuadTree implementation. > BUG=skia:2242 > > Committed: http://code.google.com/p/skia/source/detail?r=13736 TBR=tomhudson@google.com,mtklein@google.com,reed@google.com,iancottrell@google.com NOTREECHECKS=true NOTRY=true BUG=skia:2242 Committed: http://code.google.com/p/skia/source/detail?r=13737

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+328 lines, -117 lines) Patch
M tools/PictureRenderer.h View 1 chunk +0 lines, -2 lines 0 comments Download
M tools/bbh_shootout.cpp View 3 chunks +328 lines, -115 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
hal.canary
Created Revert of New version of the bbh shootout
6 years, 9 months ago (2014-03-11 14:23:33 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/halcanary@google.com/194903003/1
6 years, 9 months ago (2014-03-11 14:23:36 UTC) #2
commit-bot: I haz the power
6 years, 9 months ago (2014-03-11 14:23:53 UTC) #3
Message was sent while issue was closed.
Change committed as 13737

Powered by Google App Engine
This is Rietveld 408576698