Chromium Code Reviews

Issue 1949013002: [compiler] Remove dangerous language mode accessors. (Closed)

Created:
4 years, 7 months ago by Michael Starzinger
Modified:
4 years, 7 months ago
Reviewers:
Benedikt Meurer, adamk
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[compiler] Remove dangerous language mode accessors. The language mode is no longer constant accross a compilation unit. For example the extends clause of a class literal can be in strict mode even though the surrounding function is in sloppy mode. This makes any global language mode predicate that reasons over an entire function inherently dangerous. Instead one should use the appropriate predicate on scopes or literals directly. R=bmeurer@chromium.org Committed: https://crrev.com/db1b27e8f042b1f12a8921b8a9b62bc108774790 Cr-Commit-Position: refs/heads/master@{#36010}

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+7 lines, -26 lines)
M src/compiler.h View 1 chunk +0 lines, -1 line 0 comments
M src/compiler.cc View 3 chunks +2 lines, -3 lines 0 comments
M src/compiler/js-inlining.cc View 1 chunk +1 line, -1 line 0 comments
M src/crankshaft/arm/lithium-codegen-arm.h View 1 chunk +0 lines, -2 lines 0 comments
M src/crankshaft/hydrogen.h View 1 chunk +1 line, -1 line 0 comments
M src/crankshaft/hydrogen.cc View 1 chunk +3 lines, -4 lines 0 comments
M src/crankshaft/ia32/lithium-codegen-ia32.h View 1 chunk +0 lines, -2 lines 0 comments
M src/crankshaft/mips/lithium-codegen-mips.h View 1 chunk +0 lines, -2 lines 0 comments
M src/crankshaft/mips64/lithium-codegen-mips64.h View 1 chunk +0 lines, -2 lines 0 comments
M src/crankshaft/ppc/lithium-codegen-ppc.h View 1 chunk +0 lines, -2 lines 0 comments
M src/crankshaft/s390/lithium-codegen-s390.h View 1 chunk +0 lines, -2 lines 0 comments
M src/crankshaft/x64/lithium-codegen-x64.h View 1 chunk +0 lines, -2 lines 0 comments
M src/crankshaft/x87/lithium-codegen-x87.h View 1 chunk +0 lines, -2 lines 0 comments

Messages

Total messages: 11 (5 generated)
Michael Starzinger
4 years, 7 months ago (2016-05-04 08:33:44 UTC) #1
Michael Starzinger
Benedikt: PTAL. Adam: FYI.
4 years, 7 months ago (2016-05-04 08:36:55 UTC) #4
Benedikt Meurer
lgtm
4 years, 7 months ago (2016-05-04 08:37:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1949013002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1949013002/1
4 years, 7 months ago (2016-05-04 09:23:08 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-04 09:27:31 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-04 09:29:07 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/db1b27e8f042b1f12a8921b8a9b62bc108774790
Cr-Commit-Position: refs/heads/master@{#36010}

Powered by Google App Engine