Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 19490010: Avoid duplication of OS::Thread methods for every POSIX platform. (Closed)

Created:
7 years, 5 months ago by Benedikt Meurer
Modified:
7 years, 5 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Visibility:
Public.

Description

Avoid duplication of OS::Thread methods for every POSIX platform. R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15830

Patch Set 1 #

Patch Set 2 : Tweaks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+237 lines, -650 lines) Patch
M src/platform-cygwin.cc View 1 2 chunks +0 lines, -107 lines 0 comments Download
M src/platform-freebsd.cc View 1 2 chunks +0 lines, -88 lines 0 comments Download
M src/platform-linux.cc View 1 2 chunks +0 lines, -99 lines 0 comments Download
M src/platform-macos.cc View 1 2 chunks +0 lines, -175 lines 0 comments Download
M src/platform-openbsd.cc View 1 1 chunk +0 lines, -90 lines 0 comments Download
M src/platform-posix.cc View 1 5 chunks +237 lines, -2 lines 0 comments Download
M src/platform-solaris.cc View 1 2 chunks +0 lines, -89 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Benedikt Meurer
7 years, 5 months ago (2013-07-23 12:46:49 UTC) #1
Sven Panne
lgtm
7 years, 5 months ago (2013-07-23 13:43:22 UTC) #2
Benedikt Meurer
7 years, 5 months ago (2013-07-23 13:47:59 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r15830 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698