apps/DEPS - Issue 19490002: Add a main menu to the shim that matches the one in Chrome.

Side by Side Diff: apps/DEPS

Issue 19490002: Add a main menu to the shim that matches the one in Chrome. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Localize Quit entry. Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 include_rules = [	1 include_rules = [

2 "+base",	2 "+base",

3 "+content",	3 "+content",

4 "+components/browser_context_keyed_service",	4 "+components/browser_context_keyed_service",

5 "+components/user_prefs/pref_registry_syncable.h",	5 "+components/user_prefs/pref_registry_syncable.h",

6 "+components/web_modal",	6 "+components/web_modal",

7 "+extensions",	7 "+extensions",

8 "+skia/ext",	8 "+skia/ext",

9 "+third_party/skia/include",	9 "+third_party/skia/include",

10 "+ui",	10 "+ui",

11 "+win8",	11 "+win8",

12 # Temporary allowed includes.	12 # Temporary allowed includes.

13 # TODO(benwells): remove these (http://crbug.com/159366)	13 # TODO(benwells): remove these (http://crbug.com/159366)

14 "+chrome/browser/browser_process.h",	14 "+chrome/browser/browser_process.h",

15 "+chrome/browser/chrome_notification_types.h",	15 "+chrome/browser/chrome_notification_types.h",

16 "+chrome/browser/extensions",	16 "+chrome/browser/extensions",

17 "+chrome/browser/lifetime/application_lifetime.h",	17 "+chrome/browser/lifetime/application_lifetime.h",

18 "+chrome/browser/profiles",	18 "+chrome/browser/profiles",

19 "+chrome/browser/sessions/session_id.h",	19 "+chrome/browser/sessions/session_id.h",

20 "+chrome/browser/shell_integration.h",	20 "+chrome/browser/shell_integration.h",

21 "+chrome/browser/ui/extensions/application_launch.h",	21 "+chrome/browser/ui/extensions/application_launch.h",

22 "+chrome/browser/ui/extensions/native_app_window.h",	22 "+chrome/browser/ui/extensions/native_app_window.h",

23 "+chrome/browser/ui/host_desktop.h",	23 "+chrome/browser/ui/host_desktop.h",

24 "+chrome/browser/ui/web_applications/web_app_ui.h",	24 "+chrome/browser/ui/web_applications/web_app_ui.h",

25 "+chrome/browser/web_applications/web_app.h",	25 "+chrome/browser/web_applications/web_app.h",

26 "+chrome/browser/web_applications/web_app_mac.h",	26 "+chrome/browser/web_applications/web_app_mac.h",

	27 "+chrome/common/chrome_constants.h",

27 "+chrome/common/chrome_paths.h",	28 "+chrome/common/chrome_paths.h",

28 "+chrome/common/chrome_paths_internal.h",	29 "+chrome/common/chrome_paths_internal.h",

29 "+chrome/common/chrome_switches.h",	30 "+chrome/common/chrome_switches.h",

30 "+chrome/common/extensions",	31 "+chrome/common/extensions",

31 "+chrome/common/mac/app_mode_common.h",	32 "+chrome/common/mac/app_mode_common.h",

32 "+chrome/installer",	33 "+chrome/installer",

33 "+chrome/test/base/testing_profile.h",	34 "+chrome/test/base/testing_profile.h",

	35 "+grit/generated_resources.h",
	tapted 2013/07/23 05:24:35 How does everything else avoid adding this to thei How does everything else avoid adding this to their DEPS? i.e., there doesn't appear to be precedent for 'grit' appearing in a DEPS file, according to `git grep grit -- DEPS` jackhou1 2013/07/23 06:22:22 They do have it. It shows up on Codesearch: https: Show quoted text On 2013/07/23 05:24:35, tapted wrote: > How does everything else avoid adding this to their DEPS? i.e., there doesn't > appear to be precedent for 'grit' appearing in a DEPS file, according to `git > grep grit -- DEPS` They do have it. It shows up on Codesearch: https://code.google.com/p/chromium/codesearch#search/&q=grit%20file:DEPS tapted 2013/07/23 07:39:41 ohhh derp. TIL: git grep is not recursive if it fi Show quoted text On 2013/07/23 06:22:22, jackhou1 wrote: > On 2013/07/23 05:24:35, tapted wrote: > > How does everything else avoid adding this to their DEPS? i.e., there doesn't > > appear to be precedent for 'grit' appearing in a DEPS file, according to `git > > grep grit -- DEPS` > > They do have it. It shows up on Codesearch: > https://code.google.com/p/chromium/codesearch#search/&q=grit%2520file:DEPS ohhh derp. TIL: git grep is not recursive if it finds a file in the current path matching the pathspec exactly. Seems the trick is `git grep grit -- '*DEPS'`
34 ]	36 ]

OLD	NEW

« no previous file with comments | « no previous file | apps/app_shim/chrome_main_app_mode_mac.mm » ('j') | apps/app_shim/chrome_main_app_mode_mac.mm » ('J')