Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3132)

Unified Diff: chrome/browser/storage_monitor/storage_monitor_linux_unittest.cc

Issue 19489006: Media Galleries: Move gallery name generation back to StorageMonitor. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/storage_monitor/storage_monitor_linux_unittest.cc
===================================================================
--- chrome/browser/storage_monitor/storage_monitor_linux_unittest.cc (revision 213035)
+++ chrome/browser/storage_monitor/storage_monitor_linux_unittest.cc (working copy)
@@ -91,7 +91,6 @@
StorageInfo::Type type = kTestDeviceData[i].type;
storage_info.reset(new StorageInfo(
StorageInfo::MakeDeviceId(type, kTestDeviceData[i].unique_id),
- string16(),
mount_point.value(),
ASCIIToUTF16("volume label"),
ASCIIToUTF16("vendor name"),
@@ -345,7 +344,6 @@
EXPECT_EQ(1, observer().attach_calls());
EXPECT_EQ(0, observer().detach_calls());
EXPECT_EQ(GetDeviceId(kDeviceDCIM2), observer().last_attached().device_id());
- EXPECT_EQ(string16(), observer().last_attached().name());
EXPECT_EQ(test_path.value(), observer().last_attached().location());
// |kDeviceDCIM2| should be detached here.
@@ -368,7 +366,6 @@
EXPECT_EQ(1, observer().attach_calls());
EXPECT_EQ(0, observer().detach_calls());
EXPECT_EQ(GetDeviceId(kDeviceDCIM1), observer().last_attached().device_id());
- EXPECT_EQ(string16(), observer().last_attached().name());
EXPECT_EQ(test_path_a.value(), observer().last_attached().location());
// This should do nothing, since |kDeviceFixed| is not removable.
@@ -395,7 +392,6 @@
EXPECT_EQ(2, observer().attach_calls());
EXPECT_EQ(1, observer().detach_calls());
EXPECT_EQ(GetDeviceId(kDeviceNoDCIM), observer().last_attached().device_id());
- EXPECT_EQ(string16(), observer().last_attached().name());
EXPECT_EQ(test_path_b.value(), observer().last_attached().location());
// |kDeviceNoDCIM| should be detached as expected.
@@ -622,7 +618,6 @@
EXPECT_TRUE(notifier()->GetStorageInfoForPath(test_path_a, &device_info));
EXPECT_EQ(GetDeviceId(kDeviceDCIM1), device_info.device_id());
EXPECT_EQ(test_path_a.value(), device_info.location());
- EXPECT_EQ(string16(), device_info.name());
EXPECT_EQ(88788ULL, device_info.total_size_in_bytes());
EXPECT_EQ(ASCIIToUTF16("volume label"), device_info.storage_label());
EXPECT_EQ(ASCIIToUTF16("vendor name"), device_info.vendor_name());
@@ -631,12 +626,10 @@
EXPECT_TRUE(notifier()->GetStorageInfoForPath(test_path_b, &device_info));
EXPECT_EQ(GetDeviceId(kDeviceNoDCIM), device_info.device_id());
EXPECT_EQ(test_path_b.value(), device_info.location());
- EXPECT_EQ(string16(), device_info.name());
EXPECT_TRUE(notifier()->GetStorageInfoForPath(test_path_c, &device_info));
EXPECT_EQ(GetDeviceId(kDeviceFixed), device_info.device_id());
EXPECT_EQ(test_path_c.value(), device_info.location());
- EXPECT_EQ(string16(), device_info.name());
// An invalid path.
EXPECT_FALSE(notifier()->GetStorageInfoForPath(base::FilePath(kInvalidPath),
@@ -648,7 +641,6 @@
&device_info));
EXPECT_EQ(GetDeviceId(kDeviceDCIM1), device_info.device_id());
EXPECT_EQ(test_path_a.value(), device_info.location());
- EXPECT_EQ(string16(), device_info.name());
// One device attached at multiple points.
// kDeviceDCIM1 -> kMountPointA *

Powered by Google App Engine
This is Rietveld 408576698