Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Unified Diff: chrome/browser/storage_monitor/storage_monitor_unittest.cc

Issue 19489006: Media Galleries: Move gallery name generation back to StorageMonitor. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: rebase Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/storage_monitor/storage_monitor_unittest.cc
===================================================================
--- chrome/browser/storage_monitor/storage_monitor_unittest.cc (revision 218837)
+++ chrome/browser/storage_monitor/storage_monitor_unittest.cc (working copy)
@@ -45,16 +45,14 @@
monitor.AddObserver(&observer1);
monitor.AddObserver(&observer2);
- StorageInfo info(kDeviceId1, kDeviceName, FILE_PATH_LITERAL("path"),
- string16(), string16(), string16(), 0);
+ StorageInfo info(kDeviceId1, FILE_PATH_LITERAL("path"), base::string16(),
+ base::string16(), base::string16(), 0);
monitor.receiver()->ProcessAttach(info);
message_loop.RunUntilIdle();
EXPECT_EQ(kDeviceId1, observer1.last_attached().device_id());
- EXPECT_EQ(kDeviceName, observer1.last_attached().name());
EXPECT_EQ(FILE_PATH_LITERAL("path"), observer1.last_attached().location());
EXPECT_EQ(kDeviceId1, observer2.last_attached().device_id());
- EXPECT_EQ(kDeviceName, observer2.last_attached().name());
EXPECT_EQ(FILE_PATH_LITERAL("path"), observer2.last_attached().location());
EXPECT_EQ(1, observer1.attach_calls());
EXPECT_EQ(0, observer1.detach_calls());
@@ -64,10 +62,8 @@
message_loop.RunUntilIdle();
EXPECT_EQ(kDeviceId1, observer1.last_detached().device_id());
- EXPECT_EQ(kDeviceName, observer1.last_detached().name());
EXPECT_EQ(FILE_PATH_LITERAL("path"), observer1.last_detached().location());
EXPECT_EQ(kDeviceId1, observer2.last_detached().device_id());
- EXPECT_EQ(kDeviceName, observer2.last_detached().name());
EXPECT_EQ(FILE_PATH_LITERAL("path"), observer2.last_detached().location());
EXPECT_EQ(1, observer1.attach_calls());
@@ -96,30 +92,27 @@
const std::string kDeviceId1 = "dcim:UUID:FFF0-0042";
const string16 kDeviceName1 = ASCIIToUTF16("test");
const base::FilePath kDevicePath1(FILE_PATH_LITERAL("/testfoo"));
- StorageInfo info1(kDeviceId1, kDeviceName1, kDevicePath1.value(),
- string16(), string16(), string16(), 0);
+ StorageInfo info1(kDeviceId1, kDevicePath1.value(), base::string16(),
+ base::string16(), base::string16(), 0);
monitor.receiver()->ProcessAttach(info1);
message_loop.RunUntilIdle();
std::vector<StorageInfo> devices = monitor.GetAllAvailableStorages();
ASSERT_EQ(1U, devices.size());
EXPECT_EQ(kDeviceId1, devices[0].device_id());
- EXPECT_EQ(kDeviceName1, devices[0].name());
EXPECT_EQ(kDevicePath1.value(), devices[0].location());
const std::string kDeviceId2 = "dcim:UUID:FFF0-0044";
const string16 kDeviceName2 = ASCIIToUTF16("test2");
const base::FilePath kDevicePath2(FILE_PATH_LITERAL("/testbar"));
- StorageInfo info2(kDeviceId2, kDeviceName2, kDevicePath2.value(),
- string16(), string16(), string16(), 0);
+ StorageInfo info2(kDeviceId2, kDevicePath2.value(), base::string16(),
+ base::string16(), base::string16(), 0);
monitor.receiver()->ProcessAttach(info2);
message_loop.RunUntilIdle();
devices = monitor.GetAllAvailableStorages();
ASSERT_EQ(2U, devices.size());
EXPECT_EQ(kDeviceId1, devices[0].device_id());
- EXPECT_EQ(kDeviceName1, devices[0].name());
EXPECT_EQ(kDevicePath1.value(), devices[0].location());
EXPECT_EQ(kDeviceId2, devices[1].device_id());
- EXPECT_EQ(kDeviceName2, devices[1].name());
EXPECT_EQ(kDevicePath2.value(), devices[1].location());
monitor.receiver()->ProcessDetach(kDeviceId1);
@@ -127,7 +120,6 @@
devices = monitor.GetAllAvailableStorages();
ASSERT_EQ(1U, devices.size());
EXPECT_EQ(kDeviceId2, devices[0].device_id());
- EXPECT_EQ(kDeviceName2, devices[0].name());
EXPECT_EQ(kDevicePath2.value(), devices[0].location());
monitor.receiver()->ProcessDetach(kDeviceId2);

Powered by Google App Engine
This is Rietveld 408576698