Media Galleries: Move gallery name generation back to StorageMonitor.

chrome/browser/media_galleries/media_galleries_preferences_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // MediaGalleriesPreferences unit tests.
 
 #include "chrome/browser/media_galleries/media_galleries_preferences.h"
 
 #include "base/command_line.h"
 #include "base/memory/ref_counted.h"
@@ skipping 155 matching lines @@
   }
 
   MediaGalleriesPreferences* gallery_prefs() {
     return gallery_prefs_.get();
   }
 
   uint64 default_galleries_count() {
     return default_galleries_count_;
   }
 
-  void AddGalleryExpectation(MediaGalleryPrefId id, string16 display_name,
+  void AddGalleryExpectation(MediaGalleryPrefId id,
+                             const string16& display_name,
                              std::string device_id,
                              base::FilePath relative_path,
                              MediaGalleryPrefInfo::Type type) {
     expected_galleries_[id].pref_id = id;
     expected_galleries_[id].display_name = display_name;
     expected_galleries_[id].device_id = device_id;
     expected_galleries_[id].path = relative_path.NormalizePathSeparators();
     expected_galleries_[id].type = type;
 
     if (type == MediaGalleryPrefInfo::kAutoDetected)
@@ skipping 76 matching lines @@
 TEST_F(MediaGalleriesPreferencesTest, GalleryManagement) {
   MediaGalleryPrefId auto_id, user_added_id, id;
   base::FilePath path;
   base::FilePath relative_path;
   Verify();
 
   // Add a new auto detected gallery.
   path = MakePath("new_auto");
   StorageInfo info;
   MediaStorageUtil::GetDeviceInfoFromPath(path, &info, &relative_path);
-  info.set_name(ASCIIToUTF16("NewAutoGallery"));
-  id = AddGalleryWithNameV1(info.device_id(), info.name(),
-                            relative_path, false /*auto*/);
+  base::string16 gallery_name = base::ASCIIToUTF16("NewAutoGallery");
+  id = AddGalleryWithNameV1(info.device_id(), gallery_name, relative_path,
+                            false /*auto*/);
   EXPECT_EQ(default_galleries_count() + 1UL, id);
   auto_id = id;
-  AddGalleryExpectation(id, info.name(), info.device_id(), relative_path,
+  AddGalleryExpectation(id, gallery_name, info.device_id(), relative_path,
                         MediaGalleryPrefInfo::kAutoDetected);
   Verify();
 
   // Add it again (as user), nothing should happen.
-  id = AddGalleryWithNameV1(info.device_id(), info.name(),
-                            relative_path, true /*auto*/);
+  id = AddGalleryWithNameV1(info.device_id(), gallery_name, relative_path,
+                            true /*auto*/);
   EXPECT_EQ(auto_id, id);
   Verify();
 
   // Add a new user added gallery.
   path = MakePath("new_user");
   MediaStorageUtil::GetDeviceInfoFromPath(path, &info, &relative_path);
-  info.set_name(ASCIIToUTF16("NewUserGallery"));
-  id = AddGalleryWithNameV1(info.device_id(), info.name(),
-                            relative_path, true /*user*/);
+  gallery_name = base::ASCIIToUTF16("NewUserGallery");
+  id = AddGalleryWithNameV1(info.device_id(), gallery_name, relative_path,
+                            true /*user*/);
   EXPECT_EQ(default_galleries_count() + 2UL, id);
   user_added_id = id;
-  AddGalleryExpectation(id, info.name(), info.device_id(), relative_path,
+  AddGalleryExpectation(id, gallery_name, info.device_id(), relative_path,
                         MediaGalleryPrefInfo::kUserAdded);
   Verify();
 
   // Lookup some galleries.
   EXPECT_TRUE(gallery_prefs()->LookUpGalleryByPath(MakePath("new_auto"), NULL));
   EXPECT_TRUE(gallery_prefs()->LookUpGalleryByPath(MakePath("new_user"), NULL));
   EXPECT_FALSE(gallery_prefs()->LookUpGalleryByPath(MakePath("other"), NULL));
 
   // Check that we always get the gallery info.
   MediaGalleryPrefInfo gallery_info;
@@ skipping 69 matching lines @@
   MediaGalleryPrefId id, metadata_id;
   base::FilePath path;
   StorageInfo info;
   base::FilePath relative_path;
   base::Time now = base::Time::Now();
   Verify();
 
   // Add an auto detected gallery in the prefs version 0 format.
   path = MakePath("new_auto");
   MediaStorageUtil::GetDeviceInfoFromPath(path, &info, &relative_path);
-  info.set_name(ASCIIToUTF16("NewAutoGallery"));
-  id = AddGalleryWithNameV0(info.device_id(), info.name(),
-                            relative_path, false /*auto*/);
+  base::string16 gallery_name = base::ASCIIToUTF16("NewAutoGallery");
+  id = AddGalleryWithNameV0(info.device_id(), gallery_name, relative_path,
+                            false /*auto*/);
   EXPECT_EQ(default_galleries_count() + 1UL, id);
-  AddGalleryExpectation(id, info.name(), info.device_id(), relative_path,
+  AddGalleryExpectation(id, gallery_name, info.device_id(), relative_path,
                         MediaGalleryPrefInfo::kAutoDetected);
   Verify();
 
   metadata_id = gallery_prefs()->AddGallery(info.device_id(),
                                             relative_path,
                                             false /*auto*/,
                                             ASCIIToUTF16("volume label"),
                                             ASCIIToUTF16("vendor name"),
                                             ASCIIToUTF16("model name"),
                                             1000000ULL, now);
@@ skipping 15 matching lines @@
 TEST_F(MediaGalleriesPreferencesTest, UpdateGalleryType) {
   MediaGalleryPrefId auto_id, id;
   base::FilePath path;
   StorageInfo info;
   base::FilePath relative_path;
   Verify();
 
   // Add a new auto detect gallery to test with.
   path = MakePath("new_auto");
   MediaStorageUtil::GetDeviceInfoFromPath(path, &info, &relative_path);
-  info.set_name(ASCIIToUTF16("NewAutoGallery"));
-  id = AddGalleryWithNameV1(info.device_id(), info.name(),
-                            relative_path, false /*auto*/);
+  base::string16 gallery_name = base::ASCIIToUTF16("NewAutoGallery");
+  id = AddGalleryWithNameV1(info.device_id(), gallery_name, relative_path,
+                            false /*auto*/);
   EXPECT_EQ(default_galleries_count() + 1UL, id);
   auto_id = id;
-  AddGalleryExpectation(id, info.name(), info.device_id(), relative_path,
+  AddGalleryExpectation(id, gallery_name, info.device_id(), relative_path,
                         MediaGalleryPrefInfo::kAutoDetected);
   Verify();
 
   // Remove an auto added gallery (i.e. make it blacklisted).
   gallery_prefs()->ForgetGalleryById(auto_id);
   expected_galleries_[auto_id].type = MediaGalleryPrefInfo::kBlackListed;
   expected_galleries_for_all.erase(auto_id);
   Verify();
 
   // Add the gallery again as a user action.
   id = gallery_prefs()->AddGalleryByPath(path);
   EXPECT_EQ(auto_id, id);
-  AddGalleryExpectation(id, info.name(), info.device_id(), relative_path,
+  AddGalleryExpectation(id, gallery_name, info.device_id(), relative_path,
                         MediaGalleryPrefInfo::kAutoDetected);
   Verify();
 
   // Remove an auto added gallery (i.e. make it blacklisted).
   gallery_prefs()->ForgetGalleryById(auto_id);
   expected_galleries_[auto_id].type = MediaGalleryPrefInfo::kBlackListed;
   expected_galleries_for_all.erase(auto_id);
   Verify();
 
   // Try adding the gallery again automatically and it should be a no-op.
-  id = AddGalleryWithNameV1(info.device_id(), info.name(),
-                            relative_path, false /*auto*/);
+  id = AddGalleryWithNameV1(info.device_id(), gallery_name, relative_path,
+                            false /*auto*/);
   EXPECT_EQ(auto_id, id);
   Verify();
 }
 
 TEST_F(MediaGalleriesPreferencesTest, UpdateGalleryNameV2) {
   // Add a new auto detect gallery to test with.
   base::FilePath path = MakePath("new_auto");
   StorageInfo info;
   base::FilePath relative_path;
   MediaStorageUtil::GetDeviceInfoFromPath(path, &info, &relative_path);
-  info.set_name(ASCIIToUTF16("NewAutoGallery"));
-  MediaGalleryPrefId id =
-      AddGalleryWithNameV2(info.device_id(), info.name(),
-                           relative_path, false /*auto*/);
-  AddGalleryExpectation(id, info.name(), info.device_id(), relative_path,
+  base::string16 gallery_name = base::ASCIIToUTF16("NewAutoGallery");
+  MediaGalleryPrefId id = AddGalleryWithNameV2(info.device_id(), gallery_name,
+                                               relative_path, false /*auto*/);
+  AddGalleryExpectation(id, gallery_name, info.device_id(), relative_path,
                         MediaGalleryPrefInfo::kAutoDetected);
   Verify();
 
   // Won't override the name -- don't change any expectation.
-  info.set_name(string16());
-  AddGalleryWithNameV2(info.device_id(), info.name(), relative_path, false);
+  gallery_name = base::string16();
+  AddGalleryWithNameV2(info.device_id(), gallery_name, relative_path, false);
   Verify();
 
-  info.set_name(ASCIIToUTF16("NewName"));
-  id = AddGalleryWithNameV2(info.device_id(), info.name(),
-                            relative_path, false);
+  gallery_name = base::ASCIIToUTF16("NewName");
+  id = AddGalleryWithNameV2(info.device_id(), gallery_name, relative_path,
+                            false);
   // Note: will really just update the existing expectation.
-  AddGalleryExpectation(id, info.name(), info.device_id(), relative_path,
+  AddGalleryExpectation(id, gallery_name, info.device_id(), relative_path,
                         MediaGalleryPrefInfo::kAutoDetected);
   Verify();
 }
 
 TEST_F(MediaGalleriesPreferencesTest, GalleryPermissions) {
   MediaGalleryPrefId auto_id, user_added_id, to_blacklist_id, id;
   base::FilePath path;
   StorageInfo info;
   base::FilePath relative_path;
   Verify();
 
   // Add some galleries to test with.
   path = MakePath("new_user");
   MediaStorageUtil::GetDeviceInfoFromPath(path, &info, &relative_path);
-  info.set_name(ASCIIToUTF16("NewUserGallery"));
-  id = AddGalleryWithNameV1(info.device_id(), info.name(),
-                            relative_path, true /*user*/);
+  base::string16 gallery_name = base::ASCIIToUTF16("NewUserGallery");
+  id = AddGalleryWithNameV1(info.device_id(), gallery_name, relative_path,
+                            true /*user*/);
   EXPECT_EQ(default_galleries_count() + 1UL, id);
   user_added_id = id;
-  AddGalleryExpectation(id, info.name(), info.device_id(), relative_path,
+  AddGalleryExpectation(id, gallery_name, info.device_id(), relative_path,
                         MediaGalleryPrefInfo::kUserAdded);
   Verify();
 
   path = MakePath("new_auto");
   MediaStorageUtil::GetDeviceInfoFromPath(path, &info, &relative_path);
-  info.set_name(ASCIIToUTF16("NewAutoGallery"));
-  id = AddGalleryWithNameV1(info.device_id(), info.name(),
-                            relative_path, false /*auto*/);
+  gallery_name = base::ASCIIToUTF16("NewAutoGallery");
+  id = AddGalleryWithNameV1(info.device_id(), gallery_name, relative_path,
+                            false /*auto*/);
   EXPECT_EQ(default_galleries_count() + 2UL, id);
   auto_id = id;
-  AddGalleryExpectation(id, info.name(), info.device_id(), relative_path,
+  AddGalleryExpectation(id, gallery_name, info.device_id(), relative_path,
                         MediaGalleryPrefInfo::kAutoDetected);
   Verify();
 
   path = MakePath("to_blacklist");
   MediaStorageUtil::GetDeviceInfoFromPath(path, &info, &relative_path);
-  info.set_name(ASCIIToUTF16("ToBlacklistGallery"));
-  id = AddGalleryWithNameV1(info.device_id(), info.name(),
-                            relative_path, false /*auto*/);
+  gallery_name = base::ASCIIToUTF16("ToBlacklistGallery");
+  id = AddGalleryWithNameV1(info.device_id(), gallery_name, relative_path,
+                            false /*auto*/);
   EXPECT_EQ(default_galleries_count() + 3UL, id);
   to_blacklist_id = id;
-  AddGalleryExpectation(id, info.name(), info.device_id(), relative_path,
+  AddGalleryExpectation(id, gallery_name, info.device_id(), relative_path,
                         MediaGalleryPrefInfo::kAutoDetected);
   Verify();
 
   // Remove permission for all galleries from the all-permission extension.
   gallery_prefs()->SetGalleryPermissionForExtension(
       *all_permission_extension.get(), auto_id, false);
   expected_galleries_for_all.erase(auto_id);
   Verify();
 
   gallery_prefs()->SetGalleryPermissionForExtension(
@@ skipping 70 matching lines @@
 TEST_F(MediaGalleriesPreferencesTest, UpdateGalleryDetails) {
   MediaGalleryPrefId auto_id, id;
   base::FilePath path;
   StorageInfo info;
   base::FilePath relative_path;
   Verify();
 
   // Add a new auto detect gallery to test with.
   path = MakePath("new_auto");
   MediaStorageUtil::GetDeviceInfoFromPath(path, &info, &relative_path);
-  info.set_name(ASCIIToUTF16("NewAutoGallery"));
-  id = AddGalleryWithNameV1(info.device_id(), info.name(),
-                            relative_path, false /*auto*/);
+  base::string16 gallery_name = base::ASCIIToUTF16("NewAutoGallery");
+  id = AddGalleryWithNameV1(info.device_id(), gallery_name, relative_path,
+                            false /*auto*/);
   EXPECT_EQ(default_galleries_count() + 1UL, id);
   auto_id = id;
-  AddGalleryExpectation(id, info.name(), info.device_id(), relative_path,
+  AddGalleryExpectation(id, gallery_name, info.device_id(), relative_path,
                         MediaGalleryPrefInfo::kAutoDetected);
   Verify();
 
   // Update the device name and add the gallery again.
-  info.set_name(ASCIIToUTF16("AutoGallery2"));
-  id = AddGalleryWithNameV1(info.device_id(), info.name(),
-                            relative_path, false /*auto*/);
+  gallery_name = base::ASCIIToUTF16("AutoGallery2");
+  id = AddGalleryWithNameV1(info.device_id(), gallery_name, relative_path,
+                            false /*auto*/);
   EXPECT_EQ(auto_id, id);
-  AddGalleryExpectation(id, info.name(), info.device_id(), relative_path,
+  AddGalleryExpectation(id, gallery_name, info.device_id(), relative_path,
                         MediaGalleryPrefInfo::kAutoDetected);
   Verify();
 }
 
 TEST_F(MediaGalleriesPreferencesTest, MultipleGalleriesPerDevices) {
   base::FilePath path;
   StorageInfo info;
   base::FilePath relative_path;
   Verify();
 
   // Add a regular gallery
   path = MakePath("new_user");
   MediaStorageUtil::GetDeviceInfoFromPath(path, &info, &relative_path);
-  info.set_name(ASCIIToUTF16("NewUserGallery"));
-  MediaGalleryPrefId user_added_id =
-      AddGalleryWithNameV1(info.device_id(), info.name(),
-                           relative_path, true /*user*/);
+  base::string16 gallery_name = base::ASCIIToUTF16("NewUserGallery");
+  MediaGalleryPrefId user_added_id = AddGalleryWithNameV1(
+      info.device_id(), gallery_name, relative_path, true /*user*/);
   EXPECT_EQ(default_galleries_count() + 1UL, user_added_id);
-  AddGalleryExpectation(user_added_id, info.name(), info.device_id(),
+  AddGalleryExpectation(user_added_id, gallery_name, info.device_id(),
                         relative_path, MediaGalleryPrefInfo::kUserAdded);
   Verify();
 
   // Find it by device id and fail to find something related.
   MediaGalleryPrefIdSet pref_id_set;
   pref_id_set = gallery_prefs()->LookUpGalleriesByDeviceId(info.device_id());
   EXPECT_EQ(1U, pref_id_set.size());
   EXPECT_TRUE(pref_id_set.find(user_added_id) != pref_id_set.end());
 
   MediaStorageUtil::GetDeviceInfoFromPath(MakePath("new_user/foo"), &info,
                                           &relative_path);
   pref_id_set = gallery_prefs()->LookUpGalleriesByDeviceId(info.device_id());
   EXPECT_EQ(0U, pref_id_set.size());
 
   // Add some galleries on the same device.
   relative_path = base::FilePath(FILE_PATH_LITERAL("path1/on/device1"));
-  info.set_name(ASCIIToUTF16("Device1Path1"));
+  gallery_name = base::ASCIIToUTF16("Device1Path1");
   std::string device_id = "path:device1";
   MediaGalleryPrefId dev1_path1_id = AddGalleryWithNameV1(
-      device_id, info.name(), relative_path, true /*user*/);
+      device_id, gallery_name, relative_path, true /*user*/);
   EXPECT_EQ(default_galleries_count() + 2UL, dev1_path1_id);
-  AddGalleryExpectation(dev1_path1_id, info.name(), device_id, relative_path,
+  AddGalleryExpectation(dev1_path1_id, gallery_name, device_id, relative_path,
                         MediaGalleryPrefInfo::kUserAdded);
   Verify();
 
   relative_path = base::FilePath(FILE_PATH_LITERAL("path2/on/device1"));
-  info.set_name(ASCIIToUTF16("Device1Path2"));
+  gallery_name = base::ASCIIToUTF16("Device1Path2");
   MediaGalleryPrefId dev1_path2_id = AddGalleryWithNameV1(
-      device_id, info.name(), relative_path, true /*user*/);
+      device_id, gallery_name, relative_path, true /*user*/);
   EXPECT_EQ(default_galleries_count() + 3UL, dev1_path2_id);
-  AddGalleryExpectation(dev1_path2_id, info.name(), device_id, relative_path,
+  AddGalleryExpectation(dev1_path2_id, gallery_name, device_id, relative_path,
                         MediaGalleryPrefInfo::kUserAdded);
   Verify();
 
   relative_path = base::FilePath(FILE_PATH_LITERAL("path1/on/device2"));
-  info.set_name(ASCIIToUTF16("Device2Path1"));
+  gallery_name = base::ASCIIToUTF16("Device2Path1");
   device_id = "path:device2";
   MediaGalleryPrefId dev2_path1_id = AddGalleryWithNameV1(
-      device_id, info.name(), relative_path, true /*user*/);
+      device_id, gallery_name, relative_path, true /*user*/);
   EXPECT_EQ(default_galleries_count() + 4UL, dev2_path1_id);
-  AddGalleryExpectation(dev2_path1_id, info.name(), device_id, relative_path,
+  AddGalleryExpectation(dev2_path1_id, gallery_name, device_id, relative_path,
                         MediaGalleryPrefInfo::kUserAdded);
   Verify();
 
   relative_path = base::FilePath(FILE_PATH_LITERAL("path2/on/device2"));
-  info.set_name(ASCIIToUTF16("Device2Path2"));
+  gallery_name = base::ASCIIToUTF16("Device2Path2");
   MediaGalleryPrefId dev2_path2_id = AddGalleryWithNameV1(
-      device_id, info.name(), relative_path, true /*user*/);
+      device_id, gallery_name, relative_path, true /*user*/);
   EXPECT_EQ(default_galleries_count() + 5UL, dev2_path2_id);
-  AddGalleryExpectation(dev2_path2_id, info.name(), device_id, relative_path,
+  AddGalleryExpectation(dev2_path2_id, gallery_name, device_id, relative_path,
                         MediaGalleryPrefInfo::kUserAdded);
   Verify();
 
   // Check that adding one of them again works as expected.
   MediaGalleryPrefId id = AddGalleryWithNameV1(
-      device_id, info.name(), relative_path, true /*user*/);
+      device_id, gallery_name, relative_path, true /*user*/);
   EXPECT_EQ(dev2_path2_id, id);
   Verify();
 }
 
 TEST_F(MediaGalleriesPreferencesTest, GalleryChangeObserver) {
   // Start with one observer.
   MockGalleryChangeObserver observer1(gallery_prefs());
   gallery_prefs()->AddGalleryChangeObserver(&observer1);
 
   // Add a new auto detected gallery.
   base::FilePath path = MakePath("new_auto");
   StorageInfo info;
   base::FilePath relative_path;
   MediaStorageUtil::GetDeviceInfoFromPath(path, &info, &relative_path);
-  info.set_name(ASCIIToUTF16("NewAutoGallery"));
+  base::string16 gallery_name = base::ASCIIToUTF16("NewAutoGallery");
   MediaGalleryPrefId auto_id = AddGalleryWithNameV1(
-      info.device_id(), info.name(), relative_path, false /*auto*/);
+      info.device_id(), gallery_name, relative_path, false /*auto*/);
   EXPECT_EQ(default_galleries_count() + 1UL, auto_id);
-  AddGalleryExpectation(auto_id, info.name(), info.device_id(),
+  AddGalleryExpectation(auto_id, gallery_name, info.device_id(),
                         relative_path, MediaGalleryPrefInfo::kAutoDetected);
   EXPECT_EQ(1, observer1.notifications());
 
   // Add a second observer.
   MockGalleryChangeObserver observer2(gallery_prefs());
   gallery_prefs()->AddGalleryChangeObserver(&observer2);
 
   // Add a new user added gallery.
   path = MakePath("new_user");
   MediaStorageUtil::GetDeviceInfoFromPath(path, &info, &relative_path);
-  info.set_name(ASCIIToUTF16("NewUserGallery"));
-  MediaGalleryPrefId user_added_id =
-      AddGalleryWithNameV1(info.device_id(), info.name(),
-                           relative_path, true /*user*/);
-  AddGalleryExpectation(user_added_id, info.name(), info.device_id(),
+  gallery_name = base::ASCIIToUTF16("NewUserGallery");
+  MediaGalleryPrefId user_added_id = AddGalleryWithNameV1(
+      info.device_id(), gallery_name, relative_path, true /*user*/);
+  AddGalleryExpectation(user_added_id, gallery_name, info.device_id(),
                         relative_path, MediaGalleryPrefInfo::kUserAdded);
   EXPECT_EQ(default_galleries_count() + 2UL, user_added_id);
   EXPECT_EQ(2, observer1.notifications());
   EXPECT_EQ(1, observer2.notifications());
 
   // Remove the first observer.
   gallery_prefs()->RemoveGalleryChangeObserver(&observer1);
 
   // Remove an auto added gallery (i.e. make it blacklisted).
   gallery_prefs()->ForgetGalleryById(auto_id);
@@ skipping 15 matching lines @@
 TEST_F(MediaGalleriesPreferencesTest, UpdateSingletonDeviceIdType) {
   MediaGalleryPrefId id;
   base::FilePath path;
   StorageInfo info;
   base::FilePath relative_path;
   Verify();
 
   // Add a new auto detect gallery to test with.
   path = MakePath("new_auto");
   MediaStorageUtil::GetDeviceInfoFromPath(path, &info, &relative_path);
-  info.set_name(ASCIIToUTF16("NewAutoGallery"));
+  base::string16 gallery_name = base::ASCIIToUTF16("NewAutoGallery");
   info.set_device_id(StorageInfo::MakeDeviceId(StorageInfo::ITUNES,
                                                path.AsUTF8Unsafe()));
-  id = AddGalleryWithNameV2(info.device_id(), info.name(), relative_path,
+  id = AddGalleryWithNameV2(info.device_id(), gallery_name, relative_path,
                             false /*auto*/);
   EXPECT_EQ(default_galleries_count() + 1UL, id);
-  AddGalleryExpectation(id, info.name(), info.device_id(), relative_path,
+  AddGalleryExpectation(id, gallery_name, info.device_id(), relative_path,
                         MediaGalleryPrefInfo::kAutoDetected);
   Verify();
 
   // Update the device id.
   MockGalleryChangeObserver observer(gallery_prefs());
   gallery_prefs()->AddGalleryChangeObserver(&observer);
 
   path = MakePath("updated_path");
   std::string updated_device_id =
       StorageInfo::MakeDeviceId(StorageInfo::ITUNES, path.AsUTF8Unsafe());
   EXPECT_TRUE(UpdateDeviceIDForSingletonType(updated_device_id));
-  AddGalleryExpectation(id, info.name(), updated_device_id, relative_path,
+  AddGalleryExpectation(id, gallery_name, updated_device_id, relative_path,
                         MediaGalleryPrefInfo::kAutoDetected);
   expected_device_map[info.device_id()].erase(id);
   expected_device_map[updated_device_id].insert(id);
   Verify();
   EXPECT_EQ(1, observer.notifications());
 
   // No gallery for type.
   std::string new_device_id =
       StorageInfo::MakeDeviceId(StorageInfo::PICASA, path.AsUTF8Unsafe());
   EXPECT_FALSE(UpdateDeviceIDForSingletonType(new_device_id));
@@ skipping 23 matching lines @@
             info.GetGalleryAdditionalDetails());
   EXPECT_NE(l10n_util::GetStringUTF16(
                 IDS_MEDIA_GALLERIES_DIALOG_DEVICE_ATTACHED),
             info.GetGalleryAdditionalDetails());
 
   info.volume_label = ASCIIToUTF16("vol");
   info.vendor_name = ASCIIToUTF16("vendor");
   info.model_name = ASCIIToUTF16("model");
   EXPECT_EQ(ASCIIToUTF16("o2"), info.GetGalleryDisplayName());
 
-  info.display_name = string16();
+  info.display_name = base::string16();
   EXPECT_EQ(ASCIIToUTF16("vol"), info.GetGalleryDisplayName());
-  info.volume_label = string16();
+  info.volume_label = base::string16();
   EXPECT_EQ(ASCIIToUTF16("vendor, model"), info.GetGalleryDisplayName());
 
   info.device_id = StorageInfo::MakeDeviceId(
       StorageInfo::FIXED_MASS_STORAGE, "unique");
   EXPECT_EQ(base::FilePath(FILE_PATH_LITERAL("unique")).AsUTF8Unsafe(),
             UTF16ToUTF8(info.GetGalleryTooltip()));
 }
 
 }  // namespace chrome