Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Side by Side Diff: src/x64/full-codegen-x64.cc

Issue 19489003: Unify SMI case inlining for ToNumberStub. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/mips/full-codegen-mips.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 4402 matching lines...) Expand 10 before | Expand all | Expand 10 after
4413 // We need a second deoptimization point after loading the value 4413 // We need a second deoptimization point after loading the value
4414 // in case evaluating the property load my have a side effect. 4414 // in case evaluating the property load my have a side effect.
4415 if (assign_type == VARIABLE) { 4415 if (assign_type == VARIABLE) {
4416 PrepareForBailout(expr->expression(), TOS_REG); 4416 PrepareForBailout(expr->expression(), TOS_REG);
4417 } else { 4417 } else {
4418 PrepareForBailoutForId(prop->LoadId(), TOS_REG); 4418 PrepareForBailoutForId(prop->LoadId(), TOS_REG);
4419 } 4419 }
4420 4420
4421 // Call ToNumber only if operand is not a smi. 4421 // Call ToNumber only if operand is not a smi.
4422 Label no_conversion; 4422 Label no_conversion;
4423 __ JumpIfSmi(rax, &no_conversion, Label::kNear); 4423 if (ShouldInlineSmiCase(expr->op())) {
4424 __ JumpIfSmi(rax, &no_conversion, Label::kNear);
4425 }
4424 ToNumberStub convert_stub; 4426 ToNumberStub convert_stub;
4425 __ CallStub(&convert_stub); 4427 __ CallStub(&convert_stub);
4426 __ bind(&no_conversion); 4428 __ bind(&no_conversion);
4427 4429
4428 // Save result for postfix expressions. 4430 // Save result for postfix expressions.
4429 if (expr->is_postfix()) { 4431 if (expr->is_postfix()) {
4430 if (!context()->IsEffect()) { 4432 if (!context()->IsEffect()) {
4431 // Save the result on the stack. If we have a named or keyed property 4433 // Save the result on the stack. If we have a named or keyed property
4432 // we store the result under the receiver that is currently on top 4434 // we store the result under the receiver that is currently on top
4433 // of the stack. 4435 // of the stack.
(...skipping 469 matching lines...) Expand 10 before | Expand all | Expand 10 after
4903 *context_length = 0; 4905 *context_length = 0;
4904 return previous_; 4906 return previous_;
4905 } 4907 }
4906 4908
4907 4909
4908 #undef __ 4910 #undef __
4909 4911
4910 } } // namespace v8::internal 4912 } } // namespace v8::internal
4911 4913
4912 #endif // V8_TARGET_ARCH_X64 4914 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/mips/full-codegen-mips.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698