Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Side by Side Diff: src/mips/full-codegen-mips.cc

Issue 19489003: Unify SMI case inlining for ToNumberStub. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/full-codegen-arm.cc ('k') | src/x64/full-codegen-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 4452 matching lines...) Expand 10 before | Expand all | Expand 10 after
4463 // We need a second deoptimization point after loading the value 4463 // We need a second deoptimization point after loading the value
4464 // in case evaluating the property load my have a side effect. 4464 // in case evaluating the property load my have a side effect.
4465 if (assign_type == VARIABLE) { 4465 if (assign_type == VARIABLE) {
4466 PrepareForBailout(expr->expression(), TOS_REG); 4466 PrepareForBailout(expr->expression(), TOS_REG);
4467 } else { 4467 } else {
4468 PrepareForBailoutForId(prop->LoadId(), TOS_REG); 4468 PrepareForBailoutForId(prop->LoadId(), TOS_REG);
4469 } 4469 }
4470 4470
4471 // Call ToNumber only if operand is not a smi. 4471 // Call ToNumber only if operand is not a smi.
4472 Label no_conversion; 4472 Label no_conversion;
4473 __ JumpIfSmi(v0, &no_conversion); 4473 if (ShouldInlineSmiCase(expr->op())) {
4474 __ JumpIfSmi(v0, &no_conversion);
4475 }
4474 __ mov(a0, v0); 4476 __ mov(a0, v0);
4475 ToNumberStub convert_stub; 4477 ToNumberStub convert_stub;
4476 __ CallStub(&convert_stub); 4478 __ CallStub(&convert_stub);
4477 __ bind(&no_conversion); 4479 __ bind(&no_conversion);
4478 4480
4479 // Save result for postfix expressions. 4481 // Save result for postfix expressions.
4480 if (expr->is_postfix()) { 4482 if (expr->is_postfix()) {
4481 if (!context()->IsEffect()) { 4483 if (!context()->IsEffect()) {
4482 // Save the result on the stack. If we have a named or keyed property 4484 // Save the result on the stack. If we have a named or keyed property
4483 // we store the result under the receiver that is currently on top 4485 // we store the result under the receiver that is currently on top
(...skipping 462 matching lines...) Expand 10 before | Expand all | Expand 10 after
4946 *context_length = 0; 4948 *context_length = 0;
4947 return previous_; 4949 return previous_;
4948 } 4950 }
4949 4951
4950 4952
4951 #undef __ 4953 #undef __
4952 4954
4953 } } // namespace v8::internal 4955 } } // namespace v8::internal
4954 4956
4955 #endif // V8_TARGET_ARCH_MIPS 4957 #endif // V8_TARGET_ARCH_MIPS
OLDNEW
« no previous file with comments | « src/arm/full-codegen-arm.cc ('k') | src/x64/full-codegen-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698